Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 516603004: [ServiceWorker] Support setting body to Request object in ServiceWorker. (Closed)

Created:
6 years, 3 months ago by horo
Modified:
6 years, 3 months ago
Reviewers:
yhirano
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[ServiceWorker] Support setting body to Request object in ServiceWorker. BUG=402387 TEST=run_webkit_tests http/tests/serviceworker/request.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181176

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 2

Patch Set 3 : incorporated yhirano's comment #

Total comments: 15

Patch Set 4 : incorporated yhirano's comment #

Total comments: 2

Patch Set 5 : incorporated yhirano's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+227 lines, -15 lines) Patch
M LayoutTests/http/tests/serviceworker/resources/request-worker.js View 1 2 3 4 2 chunks +99 lines, -0 lines 0 comments Download
M Source/modules/modules.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/serviceworkers/FetchRequestData.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/serviceworkers/Request.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/modules/serviceworkers/Request.cpp View 4 chunks +28 lines, -4 lines 0 comments Download
M Source/modules/serviceworkers/RequestInit.h View 1 2 3 1 chunk +7 lines, -11 lines 0 comments Download
A Source/modules/serviceworkers/RequestInit.cpp View 1 2 3 4 1 chunk +89 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (1 generated)
horo
horo@chromium.org changed reviewers: + yhirano@chromium.org
6 years, 3 months ago (2014-08-28 14:01:08 UTC) #1
horo
yhirano@ Could you please review this?
6 years, 3 months ago (2014-08-28 14:01:08 UTC) #2
yhirano
Sorry, I will look into it next Monday. https://codereview.chromium.org/516603004/diff/20001/Source/modules/serviceworkers/RequestInit.cpp File Source/modules/serviceworkers/RequestInit.cpp (right): https://codereview.chromium.org/516603004/diff/20001/Source/modules/serviceworkers/RequestInit.cpp#newcode78 Source/modules/serviceworkers/RequestInit.cpp:78: } ...
6 years, 3 months ago (2014-08-29 15:56:07 UTC) #3
horo
https://codereview.chromium.org/516603004/diff/20001/Source/modules/serviceworkers/RequestInit.cpp File Source/modules/serviceworkers/RequestInit.cpp (right): https://codereview.chromium.org/516603004/diff/20001/Source/modules/serviceworkers/RequestInit.cpp#newcode78 Source/modules/serviceworkers/RequestInit.cpp:78: } On 2014/08/29 15:56:07, yhirano wrote: > else { ...
6 years, 3 months ago (2014-09-01 02:31:28 UTC) #4
yhirano
https://codereview.chromium.org/516603004/diff/40001/Source/modules/serviceworkers/Request.h File Source/modules/serviceworkers/Request.h (right): https://codereview.chromium.org/516603004/diff/40001/Source/modules/serviceworkers/Request.h#newcode49 Source/modules/serviceworkers/Request.h:49: void setBodyBlobHandle(PassRefPtr<BlobDataHandle>); Is this function used? https://codereview.chromium.org/516603004/diff/40001/Source/modules/serviceworkers/RequestInit.cpp File Source/modules/serviceworkers/RequestInit.cpp ...
6 years, 3 months ago (2014-09-01 06:21:56 UTC) #5
horo
https://codereview.chromium.org/516603004/diff/40001/Source/modules/serviceworkers/Request.h File Source/modules/serviceworkers/Request.h (right): https://codereview.chromium.org/516603004/diff/40001/Source/modules/serviceworkers/Request.h#newcode49 Source/modules/serviceworkers/Request.h:49: void setBodyBlobHandle(PassRefPtr<BlobDataHandle>); On 2014/09/01 06:21:56, yhirano wrote: > Is ...
6 years, 3 months ago (2014-09-01 07:29:32 UTC) #6
yhirano
lgtm https://codereview.chromium.org/516603004/diff/40001/Source/modules/serviceworkers/Request.h File Source/modules/serviceworkers/Request.h (right): https://codereview.chromium.org/516603004/diff/40001/Source/modules/serviceworkers/Request.h#newcode49 Source/modules/serviceworkers/Request.h:49: void setBodyBlobHandle(PassRefPtr<BlobDataHandle>); On 2014/09/01 07:29:32, horo wrote: > ...
6 years, 3 months ago (2014-09-01 08:36:30 UTC) #7
horo
https://codereview.chromium.org/516603004/diff/40001/Source/modules/serviceworkers/RequestInit.cpp File Source/modules/serviceworkers/RequestInit.cpp (right): https://codereview.chromium.org/516603004/diff/40001/Source/modules/serviceworkers/RequestInit.cpp#newcode56 Source/modules/serviceworkers/RequestInit.cpp:56: blobData->appendData(rawData, 0, -1); On 2014/09/01 08:36:30, yhirano wrote: > ...
6 years, 3 months ago (2014-09-01 09:03:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/516603004/80001
6 years, 3 months ago (2014-09-01 09:04:04 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-01 10:17:20 UTC) #11
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as 181176

Powered by Google App Engine
This is Rietveld 408576698