Issue 516593002: Add test that confirms Pictures don't leak pixel refs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 516593002: Add test that confirms Pictures don't leak pixel refs. (Closed)

Created:
6 years, 3 months ago by mtklein_C

Modified:
6 years, 3 months ago

Reviewers:
bungeman-skia, mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Add test that confirms Pictures don't leak pixel refs. Have been investigating memory leak failures that show SkRecords' ImmutableBitmap copy leaking. I think this test proves its not an obvious problem with ImmutableBitmap or SkRecord. http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%282%29/builds/2509/steps/interactive_ui_tests/logs/stdio BUG=skia: Committed: https://skia.googlesource.com/skia/+/d72094d1c1062a9daa6fa92682ef29f02ba59335

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -0 lines)			Patch
	M	tests/PictureTest.cpp	View		2 chunks	+29 lines, -0 lines	0 comments	Download

Total messages: 6 (0 generated)

mtklein

mtklein@google.com changed reviewers: + bungeman@google.com, mtklein@google.com

6 years, 3 months ago (2014-08-27 19:03:08 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/516593002/1

6 years, 3 months ago (2014-08-27 19:05:10 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-08-27 19:12:28 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as d72094d1c1062a9daa6fa92682ef29f02ba59335