Use platform slop/timeout values for selection handle tap detection

content/browser/renderer_host/input/touch_selection_controller_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/input/touch_selection_controller.h"
 
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/events/test/mock_motion_event.h"
 
 using ui::test::MockMotionEvent;
 
 namespace content {
 namespace {
 
+const int kDefaultTapTimeoutMs = 200;
+const float kDefaulTapSlop = 10.f;
+
 class MockTouchHandleDrawable : public TouchHandleDrawable {
  public:
   explicit MockTouchHandleDrawable(bool* contains_point)
       : intersects_rect_(contains_point) {}
   virtual ~MockTouchHandleDrawable() {}
   virtual void SetEnabled(bool enabled) OVERRIDE {}
   virtual void SetOrientation(TouchHandleOrientation orientation) OVERRIDE {}
   virtual void SetAlpha(float alpha) OVERRIDE {}
   virtual void SetFocus(const gfx::PointF& position) OVERRIDE {}
   virtual void SetVisible(bool visible) OVERRIDE {}
@@ skipping 15 matching lines @@
         caret_moved_(false),
         selection_moved_(false),
         needs_animate_(false),
         animation_enabled_(true),
         dragging_enabled_(false) {}
 
   virtual ~TouchSelectionControllerTest() {}
 
   // testing::Test implementation.
   virtual void SetUp() OVERRIDE {
-    controller_.reset(new TouchSelectionController(this));
+    controller_.reset(new TouchSelectionController(
+        this,
+        base::TimeDelta::FromMilliseconds(kDefaultTapTimeoutMs),
+        kDefaulTapSlop));
   }
 
   virtual void TearDown() OVERRIDE { controller_.reset(); }
 
   // TouchSelectionControllerClient implementation.
 
   virtual bool SupportsAnimation() const OVERRIDE { return animation_enabled_; }
 
   virtual void SetNeedsAnimate() OVERRIDE { needs_animate_ = true; }
 
@@ skipping 323 matching lines @@
                           0);
   EXPECT_TRUE(controller().WillHandleTouchEvent(event));
   EXPECT_EQ(INSERTION_DRAG_STARTED, GetLastEventType());
 
   // Reset the insertion.
   ClearInsertion();
   controller().OnTapEvent();
   ChangeInsertion(start_rect, visible);
   ASSERT_EQ(INSERTION_SHOWN, GetLastEventType());
 
+  // No tap should be signalled if the drag was too long.
+  event = MockMotionEvent(MockMotionEvent::ACTION_DOWN, event_time, 0, 0);
+  EXPECT_TRUE(controller().WillHandleTouchEvent(event));
+  event = MockMotionEvent(MockMotionEvent::ACTION_MOVE, event_time, 100, 0);
+  EXPECT_TRUE(controller().WillHandleTouchEvent(event));
+  event = MockMotionEvent(MockMotionEvent::ACTION_UP, event_time, 100, 0);
+  EXPECT_TRUE(controller().WillHandleTouchEvent(event));
+  EXPECT_EQ(INSERTION_DRAG_STARTED, GetLastEventType());
+
+  // Reset the insertion.
+  ClearInsertion();
+  controller().OnTapEvent();
+  ChangeInsertion(start_rect, visible);
+  ASSERT_EQ(INSERTION_SHOWN, GetLastEventType());
+
   // No tap should be signalled if the touch sequence is cancelled.
   event = MockMotionEvent(MockMotionEvent::ACTION_DOWN, event_time, 0, 0);
   EXPECT_TRUE(controller().WillHandleTouchEvent(event));
   event = MockMotionEvent(MockMotionEvent::ACTION_CANCEL, event_time, 0, 0);
   EXPECT_TRUE(controller().WillHandleTouchEvent(event));
   EXPECT_EQ(INSERTION_DRAG_STARTED, GetLastEventType());
 }
 
 TEST_F(TouchSelectionControllerTest, InsertionNotResetByRepeatedTapOrPress) {
   base::TimeTicks event_time = base::TimeTicks::Now();
@@ skipping 245 matching lines @@
   EXPECT_EQ(SELECTION_SHOWN, GetLastEventType());
   EXPECT_EQ(start_rect.bottom_left(), GetLastEventAnchor());
 
   controller().OnTapEvent();
   ClearSelection();
   EXPECT_EQ(SELECTION_CLEARED, GetLastEventType());
   EXPECT_EQ(gfx::PointF(), GetLastEventAnchor());
 }
 
 }  // namespace content