Use platform slop/timeout values for selection handle tap detection

Use platform slop/timeout values for selection handle tap detection

Currently, selection handle taps are detected using a basic, hard-coded
timeout threshold. Update this logic to use the platform tap timeout and
scroll slop values, ensuring tap detection consistentcy with the
platform.

BUG=394093, 407963
Committed: https://crrev.com/46595ef3f9848e8c32b2589e658dc23214a06d03
Cr-Commit-Position: refs/heads/master@{#292748}

[jdduke (slow), 2014-08-27 20:07:34]

jdduke@chromium.org changed reviewers:
+ cjhopman@chromium.org

[jdduke (slow), 2014-08-27 20:07:34]

cjhopman@: I've been sitting on this for a while, PTAL when you have a chance
(but note that this isn't a high priority).

[raghu, 2014-08-28 03:00:33]

r.ghatage@samsung.com changed reviewers:
+ r.ghatage@samsung.com

[raghu, 2014-08-28 03:00:33]

Hi Jdduke,
I think this will fix the major issue. But for the issue 407963, I was thinking
some clean up is also needed in onSelectionEvent in ContentViewCore.java
especially in the insertion drag and move case. Please let me know if you would
like me to check it.

https://codereview.chromium.org/516573003/diff/40001/content/browser/renderer...
File content/browser/renderer_host/input/touch_handle.cc (right):

https://codereview.chromium.org/516573003/diff/40001/content/browser/renderer...
content/browser/renderer_host/input/touch_handle.cc:145: if
(is_drag_within_tap_region_) {
Please correct me here if I am wrong. Do we need this condition. I think
|is_drag_within_tap_region_| will always be true here.

[jdduke (slow), 2014-08-28 15:37:12]

On 2014/08/28 03:00:33, rvg(OoO) wrote:
> Hi Jdduke,
> I think this will fix the major issue. But for the issue 407963, I was
thinking
> some clean up is also needed in onSelectionEvent in ContentViewCore.java
> especially in the insertion drag and move case. Please let me know if you
would
> like me to check it.

Right, I'll have to make some tweaks there I suppose.

https://codereview.chromium.org/516573003/diff/40001/content/browser/renderer...
File content/browser/renderer_host/input/touch_handle.cc (right):

https://codereview.chromium.org/516573003/diff/40001/content/browser/renderer...
content/browser/renderer_host/input/touch_handle.cc:145: if
(is_drag_within_tap_region_) {
On 2014/08/28 03:00:33, rvg(OoO) wrote:
> Please correct me here if I am wrong. Do we need this condition. I think
> |is_drag_within_tap_region_| will always be true here.

It will only be true until we exceed the slop region, after which it will be
false and we can shortcut the calculation.

[jdduke (slow), 2014-08-28 16:11:13]

On 2014/08/28 15:37:12, jdduke wrote:
> On 2014/08/28 03:00:33, rvg(OoO) wrote:
> > Hi Jdduke,
> > I think this will fix the major issue. But for the issue 407963, I was
> thinking
> > some clean up is also needed in onSelectionEvent in ContentViewCore.java
> > especially in the insertion drag and move case. Please let me know if you
> would
> > like me to check it.
> 
> Right, I'll have to make some tweaks there I suppose.

Actually, in practice I think the current behavior there is good enough, and I
don't feel it merits any additional work. There may be some corner cases where
the paste popup is briefly hidden then shown if the insertion cursor moves by a
very narrow character and you have briefly dragged then released insertion
handle.

[cjhopman, 2014-08-29 18:10:58]

lgtm

[jdduke (slow), 2014-08-29 18:13:44]

The CQ bit was checked by jdduke@chromium.org

[commit-bot: I haz the power, 2014-08-29 18:14:33]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jdduke@chromium.org/516573003/60001

[commit-bot: I haz the power, 2014-08-29 22:33:21]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[commit-bot: I haz the power, 2014-08-29 22:42:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-29 22:42:34]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jdduke (slow), 2014-08-30 00:25:50]

jdduke@chromium.org changed reviewers:
+ sievers@chromium.org

[jdduke (slow), 2014-08-30 00:25:50]

sievers@: Owner review for RWHVAndroid? Thanks.

[no sievers, 2014-08-30 01:19:22]

On 2014/08/30 00:25:50, jdduke wrote:
> sievers@: Owner review for RWHVAndroid? Thanks.

lgtm stampedy-stamp

[jdduke (slow), 2014-08-30 01:26:37]

The CQ bit was checked by jdduke@chromium.org

[commit-bot: I haz the power, 2014-08-30 01:28:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jdduke@chromium.org/516573003/60001

[commit-bot: I haz the power, 2014-08-30 01:35:33]

Committed patchset #4 (id:60001) as 9beca07f5f297ae393e8889250c7963ea89c73c3

[commit-bot: I haz the power, 2014-09-10 03:12:49]

Patchset 4 (id:??) landed as
https://crrev.com/46595ef3f9848e8c32b2589e658dc23214a06d03
Cr-Commit-Position: refs/heads/master@{#292748}