Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Unified Diff: runtime/bin/vmservice/client/lib/src/observatory_elements/service_ref.dart

Issue 51653006: Track live instance and allocation counts for classes (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/vmservice/client/lib/src/observatory_elements/service_ref.dart
diff --git a/runtime/bin/vmservice/client/lib/src/observatory_elements/service_ref.dart b/runtime/bin/vmservice/client/lib/src/observatory_elements/service_ref.dart
index 55ab66423d9c46d81fffa35cd3ea91ff776b4ce4..ed30a02a69fb3361dbc8e919e5b9be0dde778b83 100644
--- a/runtime/bin/vmservice/client/lib/src/observatory_elements/service_ref.dart
+++ b/runtime/bin/vmservice/client/lib/src/observatory_elements/service_ref.dart
@@ -16,6 +16,7 @@ class ServiceRefElement extends ObservatoryElement {
void refChanged(oldValue) {
notifyPropertyChange(#url, "", url);
notifyPropertyChange(#name, [], name);
+ notifyPropertyChange(#hoverText, "", hoverText);
}
String get url {
@@ -25,6 +26,15 @@ class ServiceRefElement extends ObservatoryElement {
return '';
}
+ String get hoverText {
+ if (ref == null) {
+ return '';
+ }
+ // Return the VM name by default.
+ var name = ref['name'];
+ return name != null ? name : '';
+ }
+
String get name {
if (ref == null) {
return '';
@@ -32,6 +42,8 @@ class ServiceRefElement extends ObservatoryElement {
String name_key = internal ? 'name' : 'user_name';
if (ref[name_key] != null) {
return ref[name_key];
+ } else if (ref['name'] != null) {
+ return ref['name'];
}
return '';
}
« no previous file with comments | « runtime/bin/vmservice/client/lib/src/observatory_elements/message_viewer.html ('k') | runtime/vm/assembler_arm.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698