Track live instance and allocation counts for classes

runtime/vm/stub_code_ia32.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"
 #if defined(TARGET_ARCH_IA32)
 
 #include "vm/assembler.h"
 #include "vm/compiler.h"
 #include "vm/dart_entry.h"
@@ skipping 580 matching lines @@
     __ j(ABOVE_EQUAL, &slow_case);
 
     // Successfully allocated the object(s), now update top to point to
     // next object start and initialize the object.
     // EAX: potential new object start.
     // EBX: potential next object start.
     // EDX: Array length as Smi.
     // EDI: Points to new space object.
     __ movl(Address(EDI, Scavenger::top_offset()), EBX);
     __ addl(EAX, Immediate(kHeapObjectTag));
+    // EDI: Size of allocation in bytes.
+    __ movl(EDI, EBX);
+    __ subl(EDI, EAX);
+    __ UpdateAllocationStatsWithSize(kArrayCid, EDI, kNoRegister);
 
     // EAX: new object start as a tagged pointer.
     // EBX: new object end address.
     // ECX: array element type.
     // EDX: Array length as Smi.
 
     // Store the type argument field.
     __ StoreIntoObjectNoBarrier(
         EAX,
         FieldAddress(EAX, Array::type_arguments_offset()),
@@ skipping 322 matching lines @@
       __ j(ABOVE_EQUAL, &slow_case, Assembler::kNearJump);
     }
 
     // Successfully allocated the object, now update top to point to
     // next object start and initialize the object.
     // EAX: new object.
     // EBX: next object start.
     // EDX: number of context variables.
     __ movl(Address::Absolute(heap->TopAddress()), EBX);
     __ addl(EAX, Immediate(kHeapObjectTag));
+    // EBX: Size of allocation in bytes.
+    __ subl(EBX, EAX);
+    __ UpdateAllocationStatsWithSize(context_class.id(), EBX, kNoRegister);
 
     // Calculate the size tag.
     // EAX: new object.
     // EDX: number of context variables.
     {
       Label size_tag_overflow, done;
       __ leal(EBX, Address(EDX, TIMES_4, fixed_size));
       __ andl(EBX, Immediate(-kObjectAlignment));
       __ cmpl(EBX, Immediate(RawObject::SizeTag::kMaxSizeTag));
       __ j(ABOVE, &size_tag_overflow, Assembler::kNearJump);
@@ skipping 181 matching lines @@
       // ECX: potential new object end and, if ECX != EBX, potential new
       // InstantiatedTypeArguments object start.
     }
     // Check if the allocation fits into the remaining space.
     // EAX: potential new object start.
     // EBX: potential next object start.
     __ cmpl(EBX, Address::Absolute(heap->EndAddress()));
     if (FLAG_use_slow_path) {
       __ jmp(&slow_case);
     } else {
-      __ j(ABOVE_EQUAL, &slow_case, Assembler::kNearJump);
+      __ j(ABOVE_EQUAL, &slow_case);
     }
 
     // Successfully allocated the object(s), now update top to point to
     // next object start and initialize the object.
     __ movl(Address::Absolute(heap->TopAddress()), EBX);
+    __ UpdateAllocationStats(cls.id(), EDI);
 
     if (is_cls_parameterized) {
       // Initialize the type arguments field in the object.
       // EAX: new object start.
       // ECX: potential new object end and, if ECX != EBX, potential new
       // InstantiatedTypeArguments object start.
       // EBX: next object start.
       Label type_arguments_ready;
       __ movl(EDI, Address(ESP, kObjectTypeArgumentsOffset));
       __ cmpl(ECX, EBX);
@@ skipping 144 matching lines @@
     __ cmpl(EBX, Address::Absolute(heap->EndAddress()));
     if (FLAG_use_slow_path) {
       __ jmp(&slow_case);
     } else {
       __ j(ABOVE_EQUAL, &slow_case, Assembler::kNearJump);
     }
 
     // Successfully allocated the object, now update top to point to
     // next object start and initialize the object.
     __ movl(Address::Absolute(heap->TopAddress()), EBX);
+    // EAX: new closure object.
+    // ECX: new context object (only if is_implicit_closure).
+    if (is_implicit_instance_closure) {
+      // EBX: context size.
+      __ movl(EBX, Immediate(context_size));
+      // EDX: Clobbered.
+     __ UpdateAllocationStatsWithSize(kContextCid, EBX, EDX);
+    }
+    // EDX: Will be clobbered.

[Ivan Posva, 2014/01/17 06:53:16]

You might want to comment in this code what the two update allocation stats
update. The upper one is a bit clearer as it uses the kContextCid as a constant.

[Cutch, 2014/01/17 18:37:59]

Done.

+    __ UpdateAllocationStats(cls.id(), EDX);
 
     // EAX: new closure object.
     // ECX: new context object (only if is_implicit_closure).
     // Set the tags.
     uword tags = 0;
     tags = RawObject::SizeTag::update(closure_size, tags);
     tags = RawObject::ClassIdTag::update(cls.id(), tags);
     __ movl(Address(EAX, Instance::tags_offset()), Immediate(tags));
 
     // Initialize the function field in the object.
     // EAX: new closure object.
     // ECX: new context object (only if is_implicit_closure).
-    // EBX: next object start.
     __ LoadObject(EDX, func);  // Load function of closure to be allocated.
     __ movl(Address(EAX, Closure::function_offset()), EDX);
 
     // Setup the context for this closure.
     if (is_implicit_instance_closure) {
       // Initialize the new context capturing the receiver.
       const Class& context_class = Class::ZoneHandle(Object::context_class());
       // Set the tags.
       uword tags = 0;
       tags = RawObject::SizeTag::update(context_size, tags);
@@ skipping 871 matching lines @@
   const Register temp = ECX;
   __ movl(left, Address(ESP, 2 * kWordSize));
   __ movl(right, Address(ESP, 1 * kWordSize));
   GenerateIdenticalWithNumberCheckStub(assembler, left, right, temp);
   __ ret();
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_IA32