Track live instance and allocation counts for classes

runtime/vm/gc_marker.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/gc_marker.h"
 
 #include <map>
 #include <utility>
 
 #include "vm/allocation.h"
@@ skipping 110 matching lines @@
 class MarkingVisitor : public ObjectPointerVisitor {
  public:
   MarkingVisitor(Isolate* isolate,
                  Heap* heap,
                  PageSpace* page_space,
                  MarkingStack* marking_stack,
                  bool visit_function_code)
       : ObjectPointerVisitor(isolate),
         heap_(heap),
         vm_heap_(Dart::vm_isolate()->heap()),
+        class_table_(isolate->class_table()),
         page_space_(page_space),
         marking_stack_(marking_stack),
         visiting_old_object_(NULL),
         visit_function_code_(visit_function_code) {
     ASSERT(heap_ != vm_heap_);
   }
 
   MarkingStack* marking_stack() const { return marking_stack_; }
 
   void VisitPointers(RawObject** first, RawObject** last) {
@@ skipping 78 matching lines @@
     if (raw_obj->IsNewObject()) {
       // TODO(iposva): Add consistency check.
       if ((visiting_old_object_ != NULL) &&
           !visiting_old_object_->IsRemembered()) {
         ASSERT(p != NULL);
         visiting_old_object_->SetRememberedBit();
         isolate()->store_buffer()->AddObjectGC(visiting_old_object_);
       }
       return;
     }
-
+    class_table_->UpdateLiveOld(raw_obj->GetClassId(), raw_obj->Size());

[Ivan Posva, 2014/01/17 06:53:16]

We only need the size for variable size objects. I am wondering whether we
should avoid getting the size for the others.

[Cutch, 2014/01/17 18:37:59]

Done.

     MarkAndPush(raw_obj);
   }
 
   void DetachCode() {
     for (int i = 0; i < skipped_code_functions_.length(); i++) {
       RawFunction* func = skipped_code_functions_[i];
       RawCode* code = func->ptr()->code_;
       if (!code->IsMarked()) {
         // If the code wasn't strongly visited through other references
         // after skipping the function's code pointer, then we disconnect the
@@ skipping 10 matching lines @@
           String name;
           name = func->ptr()->name_;
           OS::Print("Detaching code: %s\n", name.ToCString());
         }
       }
     }
   }
 
   Heap* heap_;
   Heap* vm_heap_;
+  ClassTable* class_table_;
   PageSpace* page_space_;
   MarkingStack* marking_stack_;
   RawObject* visiting_old_object_;
   typedef std::multimap<RawObject*, RawWeakProperty*> DelaySet;
   DelaySet delay_set_;
   const bool visit_function_code_;
   GrowableArray<RawFunction*> skipped_code_functions_;
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(MarkingVisitor);
 };
@@ skipping 214 matching lines @@
   MarkingWeakVisitor mark_weak;
   IterateWeakRoots(isolate, &mark_weak, invoke_api_callbacks);
   mark.Finalize();
   ProcessWeakTables(page_space);
   ProcessObjectIdTable(isolate);
 
   Epilogue(isolate, invoke_api_callbacks);
 }
 
 }  // namespace dart