Track live instance and allocation counts for classes

runtime/vm/heap.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/heap.h"
 
 #include "platform/assert.h"
 #include "platform/utils.h"
 #include "vm/flags.h"
 #include "vm/heap_histogram.h"
@@ skipping 155 matching lines @@
       if (new_space_->HadPromotionFailure()) {
         // Old collections should call the API callbacks.
         CollectGarbage(kOld, kInvokeApiCallbacks);
       }
       break;
     }
     case kOld:
     case kCode: {
       bool promotion_failure = new_space_->HadPromotionFailure();
       RecordBeforeGC(kOld, promotion_failure ? kPromotionFailure : kOldSpace);
+      UpdateClassStats();

[Ivan Posva, 2013/12/12 13:53:24]

Why isn't this being done as part of new collection? What does it really mean to
update class stats before GC?

[Cutch, 2013/12/13 01:31:09]

Agreed. Let's discuss this Friday morning. 

       old_space_->MarkSweep(invoke_api_callbacks);
       RecordAfterGC();
       PrintStats();
       UpdateObjectHistogram();
       break;
     }
     default:
       UNREACHABLE();
   }
 }
 
 
 void Heap::UpdateObjectHistogram() {
   Isolate* isolate = Isolate::Current();
   if (isolate->object_histogram() == NULL) return;
   isolate->object_histogram()->Collect();
 }
 
 
+void Heap::UpdateClassStats() {
+  Isolate* isolate = Isolate::Current();
+  ClassTable* class_table = isolate->class_table();
+  class_table->Collect();
+}
+
+
 void Heap::CollectGarbage(Space space) {
   ApiCallbacks api_callbacks;
   if (space == kOld) {
     api_callbacks = kInvokeApiCallbacks;
   } else {
     api_callbacks = kIgnoreApiCallbacks;
   }
   CollectGarbage(space, api_callbacks);
 }
 
 
 void Heap::CollectAllGarbage() {
   RecordBeforeGC(kNew, kFull);
+  UpdateClassStats();
   new_space_->Scavenge(kInvokeApiCallbacks);
   RecordAfterGC();
   PrintStats();
   RecordBeforeGC(kOld, kFull);
   old_space_->MarkSweep(kInvokeApiCallbacks);
   RecordAfterGC();
   PrintStats();
   UpdateObjectHistogram();
 }
 
@@ skipping 300 matching lines @@
     heap->DisableGrowthControl();
 }
 
 
 NoHeapGrowthControlScope::~NoHeapGrowthControlScope() {
     Heap* heap = reinterpret_cast<Isolate*>(isolate())->heap();
     heap->SetGrowthControlState(current_growth_controller_state_);
 }
 
 }  // namespace dart