Track live instance and allocation counts for classes

runtime/vm/gc_marker.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/gc_marker.h"
 
 #include <map>
 #include <utility>
 
 #include "vm/allocation.h"
@@ skipping 109 matching lines @@
 
 class MarkingVisitor : public ObjectPointerVisitor {
  public:
   MarkingVisitor(Isolate* isolate,
                  Heap* heap,
                  PageSpace* page_space,
                  MarkingStack* marking_stack)
       : ObjectPointerVisitor(isolate),
         heap_(heap),
         vm_heap_(Dart::vm_isolate()->heap()),
+        class_table_(isolate->class_table()),
         page_space_(page_space),
         marking_stack_(marking_stack),
         visiting_old_object_(NULL) {
     ASSERT(heap_ != vm_heap_);
   }
 
   MarkingStack* marking_stack() const { return marking_stack_; }
 
   void VisitPointers(RawObject** first, RawObject** last) {
     for (RawObject** current = first; current <= last; current++) {
@@ skipping 62 matching lines @@
 
     // Skip over new objects, but verify consistency of heap while at it.
     if (raw_obj->IsNewObject()) {
       // TODO(iposva): Add consistency check.
       if ((visiting_old_object_ != NULL) &&
           !visiting_old_object_->IsRemembered()) {
         ASSERT(p != NULL);
         visiting_old_object_->SetRememberedBit();
         isolate()->store_buffer()->AddObjectGC(visiting_old_object_);
       }
+      class_table_->ReportLiveNewSpace(raw_obj->GetClassId(), raw_obj->Size());

[Ivan Posva, 2013/12/12 13:53:24]

This is not correct since the marker does not trace through new objects,
suddenly the new gen live stats will only report the count/size of objects
reached from old gen, but nothing within.

The correct thing here is to not update the new stats as part of marking.

[Cutch, 2013/12/13 01:31:09]

Done.

       return;
     }
-
+    class_table_->ReportLiveOldSpace(raw_obj->GetClassId(), raw_obj->Size());

[Ivan Posva, 2013/12/12 13:53:24]

ReportLiveOldSpace -> UpdateLiveOld

[Cutch, 2013/12/13 01:31:09]

Done.

     MarkAndPush(raw_obj);
   }
 
   Heap* heap_;
   Heap* vm_heap_;
+  ClassTable* class_table_;
   PageSpace* page_space_;
   MarkingStack* marking_stack_;
   RawObject* visiting_old_object_;
   typedef std::multimap<RawObject*, RawWeakProperty*> DelaySet;
   DelaySet delay_set_;
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(MarkingVisitor);
 };
 
 
@@ skipping 210 matching lines @@
   IterateWeakRoots(isolate, &mark_weak, invoke_api_callbacks);
   mark.Finalize();
   ProcessWeakTables(page_space);
   ProcessObjectIdTable(isolate);
 
 
   Epilogue(isolate, invoke_api_callbacks);
 }
 
 }  // namespace dart