Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 516523004: Fixes to get view_manager_lib_unittests not crash (Closed)

Created:
6 years, 3 months ago by sky
Modified:
6 years, 3 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fixes to get view_manager_lib_unittests not crash . ICU may be initialized twice: once by the test suite, secondly by the app. . window_mamanger_app_.host_ may be deleted by the time we get to the destructor to try and remove something. Add check for this. BUG=none TEST=none R=viettrungluu@chromium.org Committed: https://crrev.com/2997d2df654d38113e80612109a8cfcac5098ccf Cr-Commit-Position: refs/heads/master@{#292929}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M mojo/examples/window_manager/window_manager.cc View 1 chunk +4 lines, -1 line 0 comments Download
M mojo/services/public/cpp/view_manager/lib/view_manager_test_suite.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (1 generated)
sky
sky@chromium.org changed reviewers: + viettrungluu@chromium.org - jamesr@chromium.org
6 years, 3 months ago (2014-08-28 17:49:18 UTC) #1
sky
6 years, 3 months ago (2014-08-28 17:49:24 UTC) #2
viettrungluu
lgtm
6 years, 3 months ago (2014-08-28 19:17:06 UTC) #3
sky
The CQ bit was checked by sky@chromium.org
6 years, 3 months ago (2014-08-28 19:17:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/516523004/1
6 years, 3 months ago (2014-08-28 19:19:14 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-28 20:15:13 UTC) #6
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-08-28 20:15:14 UTC) #7
sky
The CQ bit was checked by sky@chromium.org
6 years, 3 months ago (2014-08-28 20:18:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/516523004/1
6 years, 3 months ago (2014-08-28 20:18:53 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-28 20:21:13 UTC) #10
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-08-28 20:21:14 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/516523004/1
6 years, 3 months ago (2014-09-02 15:12:00 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1) as 94e1c03fe0ef5827ad403cf8a7f923710130329f
6 years, 3 months ago (2014-09-02 15:21:09 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:18:35 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2997d2df654d38113e80612109a8cfcac5098ccf
Cr-Commit-Position: refs/heads/master@{#292929}

Powered by Google App Engine
This is Rietveld 408576698