Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Unified Diff: src/gpu/effects/GrYUVtoRGBEffect.h

Issue 516463005: Add support for the Rec601 YUV color space to GrYUVtoRGBEffect. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: remove misleading comment Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/gpu/effects/GrYUVtoRGBEffect.h
diff --git a/src/gpu/effects/GrYUVtoRGBEffect.h b/src/gpu/effects/GrYUVtoRGBEffect.h
index 150acd5a9027a553fac11d5a3a5813208a9333fa..7f406431f7f16eacd24c573e91023faff19c9f13 100644
--- a/src/gpu/effects/GrYUVtoRGBEffect.h
+++ b/src/gpu/effects/GrYUVtoRGBEffect.h
@@ -12,10 +12,19 @@ class GrEffect;
class GrTexture;
namespace GrYUVtoRGBEffect {
+ enum YUVColorSpace {
rileya (GONE FROM CHROMIUM) 2014/08/28 01:03:28 Is there a better place for this enum to live?
bsalomon 2014/08/28 13:33:26 Not sure about whether there is a more natural pla
+ /** Standard JPEG color space. */
+ kJPEG,
Stephen White 2014/08/28 15:11:06 This should be kJPEG_YUVColorSpace according to Sk
rileya (GONE FROM CHROMIUM) 2014/08/28 21:05:57 Yeah, in the long term rec709 should be supported.
+ /** SDTV standard Rec. 601 color space. Uses "studio swing" [16, 235] color
+ range. See http://en.wikipedia.org/wiki/Rec._601 for details. */
+ kRec601
+ };
+
/**
* Creates an effect that performs color conversion from YUV to RGB
*/
- GrEffect* Create(GrTexture* yTexture, GrTexture* uTexture, GrTexture* vTexture);
+ GrEffect* Create(GrTexture* yTexture, GrTexture* uTexture, GrTexture* vTexture,
+ YUVColorSpace type);
};
#endif

Powered by Google App Engine
This is Rietveld 408576698