Add support for the Rec601 YUV color space to GrYUVtoRGBEffect.

src/core/SkImageGenerator.cpp

Index: src/core/SkImageGenerator.cpp
diff --git a/src/core/SkImageGenerator.cpp b/src/core/SkImageGenerator.cpp
index 7008e7b42f6dd06c367474effdc7b734fd27625d..08ee0993f75a897568064a556bad187286c8aac0 100644
--- a/src/core/SkImageGenerator.cpp
+++ b/src/core/SkImageGenerator.cpp
@@ -57,7 +57,8 @@ bool SkImageGenerator::getPixels(const SkImageInfo& info, void* pixels, size_t r
 }
 #endif
 
-bool SkImageGenerator::getYUV8Planes(SkISize sizes[3], void* planes[3], size_t rowBytes[3]) {
+bool SkImageGenerator::getYUV8Planes(SkISize sizes[3], void* planes[3], size_t rowBytes[3],
+                                     SkPixelRef::YUVColorSpace* colorSpace) {
 #ifdef SK_DEBUG
     // In all cases, we need the sizes array
     SkASSERT(sizes);
@@ -89,13 +90,21 @@ bool SkImageGenerator::getYUV8Planes(SkISize sizes[3], void* planes[3], size_t r
               (rowBytes[2] >= (size_t)sizes[2].fWidth)));
 #endif
 
-    return this->onGetYUV8Planes(sizes, planes, rowBytes);
+    return this->onGetYUV8Planes(sizes, planes, rowBytes, colorSpace);
 }
 
 bool SkImageGenerator::onGetYUV8Planes(SkISize sizes[3], void* planes[3], size_t rowBytes[3]) {
     return false;
 }
 
+bool SkImageGenerator::onGetYUV8Planes(SkISize sizes[3], void* planes[3], size_t rowBytes[3],
+                                       SkPixelRef::YUVColorSpace* colorSpace) {
+    if (colorSpace) {
+        *colorSpace = SkPixelRef::kJPEG_YUVColorSpace;

[reed1, 2014/09/11 14:58:55]

do we know its JPEG at this point? Isn't that the job of onGetYUV8Planes?

[rileya (GONE FROM CHROMIUM), 2014/09/11 17:38:38]

For the sake of working with the old (sans color space) interface, the default
impl for this assumes jpeg. Once chromium/blink override the new version of this
virtual, I plan on nuking the old one entirely and removing this (assuming
nobody anywhere else uses it?).

I'll add a comment explaining this.

[rileya (GONE FROM CHROMIUM), 2014/09/11 18:45:05]

Added a comment.

+    }
+    return onGetYUV8Planes(sizes, planes, rowBytes);
+}
+
 /////////////////////////////////////////////////////////////////////////////////////////////
 
 SkData* SkImageGenerator::onRefEncodedData() {