Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: chrome/browser/profiles/profile_io_data.h

Issue 516453002: Fix leak of MultiThreadedCertVerifier in ProfileIOData. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Clarified comment. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/profiles/profile_io_data.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/profiles/profile_io_data.h
diff --git a/chrome/browser/profiles/profile_io_data.h b/chrome/browser/profiles/profile_io_data.h
index eed446ea6c26e2d4d35af22c122920602d4e755f..b43b0d467dfd458cd78553d3dec2b98c2c014a60 100644
--- a/chrome/browser/profiles/profile_io_data.h
+++ b/chrome/browser/profiles/profile_io_data.h
@@ -47,6 +47,7 @@ class InfoMap;
}
namespace net {
+class CertVerifier;
class ChannelIDService;
class CookieStore;
class FraudulentCertificateReporter;
@@ -587,7 +588,10 @@ class ProfileIOData {
mutable scoped_ptr<net::HttpServerProperties>
http_server_properties_;
#if defined(OS_CHROMEOS)
- mutable scoped_ptr<policy::PolicyCertVerifier> cert_verifier_;
+ // Set to |cert_verifier_| if it references a PolicyCertVerifier. In that
+ // case, the verifier is owned by |cert_verifier_|. Otherwise, set to NULL.
+ mutable policy::PolicyCertVerifier* policy_cert_verifier_;
+ mutable scoped_ptr<net::CertVerifier> cert_verifier_;
mutable std::string username_hash_;
mutable bool use_system_key_slot_;
#endif
« no previous file with comments | « no previous file | chrome/browser/profiles/profile_io_data.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698