| Index: chrome/browser/net/prediction_options.cc
|
| diff --git a/chrome/browser/net/prediction_options.cc b/chrome/browser/net/prediction_options.cc
|
| index a01f5ee1144643b4286932f7b0a086fb73a7719e..f5253884a116fcbc0fb2a490bef74ceb0aa70e8c 100644
|
| --- a/chrome/browser/net/prediction_options.cc
|
| +++ b/chrome/browser/net/prediction_options.cc
|
| @@ -12,56 +12,38 @@
|
| #include "content/public/browser/browser_thread.h"
|
| #include "net/base/network_change_notifier.h"
|
|
|
| +namespace chrome_browser_net {
|
| +
|
| namespace {
|
|
|
| // Since looking up preferences and current network connection are presumably
|
| // both cheap, we do not cache them here.
|
| -bool CanPrefetchAndPrerender(int network_prediction_options,
|
| - bool network_prediction_enabled) {
|
| +bool CanPrefetchAndPrerender(int network_prediction_options) {
|
| switch (network_prediction_options) {
|
| - case chrome_browser_net::NETWORK_PREDICTION_ALWAYS:
|
| + case NETWORK_PREDICTION_ALWAYS:
|
| return true;
|
| - case chrome_browser_net::NETWORK_PREDICTION_WIFI_ONLY:
|
| - return !net::NetworkChangeNotifier::IsConnectionCellular(
|
| - net::NetworkChangeNotifier::GetConnectionType());
|
| - case chrome_browser_net::NETWORK_PREDICTION_NEVER:
|
| + case NETWORK_PREDICTION_NEVER:
|
| return false;
|
| - case chrome_browser_net::NETWORK_PREDICTION_UNSET:
|
| - return network_prediction_enabled;
|
| default:
|
| - NOTREACHED() << "Unknown kNetworkPredictionOptions value.";
|
| - return false;
|
| + DCHECK_EQ(NETWORK_PREDICTION_WIFI_ONLY, network_prediction_options);
|
| + return !net::NetworkChangeNotifier::IsConnectionCellular(
|
| + net::NetworkChangeNotifier::GetConnectionType());
|
| }
|
| }
|
|
|
| -bool CanPreresolveAndPreconnect(int network_prediction_options,
|
| - bool network_prediction_enabled) {
|
| - switch (network_prediction_options) {
|
| - case chrome_browser_net::NETWORK_PREDICTION_ALWAYS:
|
| - return true;
|
| - // DNS preresolution and TCP preconnect are performed even on cellular
|
| - // networks if the user setting is WIFI_ONLY.
|
| - case chrome_browser_net::NETWORK_PREDICTION_WIFI_ONLY:
|
| - return true;
|
| - case chrome_browser_net::NETWORK_PREDICTION_NEVER:
|
| - return false;
|
| - case chrome_browser_net::NETWORK_PREDICTION_UNSET:
|
| - return network_prediction_enabled;
|
| - default:
|
| - NOTREACHED() << "Unknown kNetworkPredictionOptions value.";
|
| - return false;
|
| - }
|
| +bool CanPreresolveAndPreconnect(int network_prediction_options) {
|
| + // DNS preresolution and TCP preconnect are performed even on cellular
|
| + // networks if the user setting is WIFI_ONLY.
|
| + return network_prediction_options != NETWORK_PREDICTION_NEVER;
|
| }
|
|
|
| } // namespace
|
|
|
| -namespace chrome_browser_net {
|
| -
|
| void RegisterPredictionOptionsProfilePrefs(
|
| user_prefs::PrefRegistrySyncable* registry) {
|
| registry->RegisterIntegerPref(
|
| prefs::kNetworkPredictionOptions,
|
| - chrome_browser_net::NETWORK_PREDICTION_UNSET,
|
| + NETWORK_PREDICTION_DEFAULT,
|
| user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
|
| }
|
|
|
| @@ -81,8 +63,7 @@ void MigrateNetworkPredictionUserPrefs(PrefService* pref_service) {
|
| if (network_prediction_enabled->GetAsBoolean(&value)) {
|
| pref_service->SetInteger(
|
| prefs::kNetworkPredictionOptions,
|
| - value ? chrome_browser_net::NETWORK_PREDICTION_WIFI_ONLY
|
| - : chrome_browser_net::NETWORK_PREDICTION_NEVER);
|
| + value ? NETWORK_PREDICTION_WIFI_ONLY : NETWORK_PREDICTION_NEVER);
|
| }
|
| }
|
|
|
| @@ -90,16 +71,14 @@ bool CanPrefetchAndPrerenderIO(ProfileIOData* profile_io_data) {
|
| DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::IO));
|
| DCHECK(profile_io_data);
|
| return CanPrefetchAndPrerender(
|
| - profile_io_data->network_prediction_options()->GetValue(),
|
| - profile_io_data->network_prediction_enabled()->GetValue());
|
| + profile_io_data->network_prediction_options()->GetValue());
|
| }
|
|
|
| bool CanPrefetchAndPrerenderUI(PrefService* prefs) {
|
| DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
|
| DCHECK(prefs);
|
| return CanPrefetchAndPrerender(
|
| - prefs->GetInteger(prefs::kNetworkPredictionOptions),
|
| - prefs->GetBoolean(prefs::kNetworkPredictionEnabled));
|
| + prefs->GetInteger(prefs::kNetworkPredictionOptions));
|
| }
|
|
|
| bool CanPredictNetworkActionsUI(PrefService* prefs) {
|
| @@ -110,16 +89,14 @@ bool CanPreresolveAndPreconnectIO(ProfileIOData* profile_io_data) {
|
| DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::IO));
|
| DCHECK(profile_io_data);
|
| return CanPreresolveAndPreconnect(
|
| - profile_io_data->network_prediction_options()->GetValue(),
|
| - profile_io_data->network_prediction_enabled()->GetValue());
|
| + profile_io_data->network_prediction_options()->GetValue());
|
| }
|
|
|
| bool CanPreresolveAndPreconnectUI(PrefService* prefs) {
|
| DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
|
| DCHECK(prefs);
|
| return CanPreresolveAndPreconnect(
|
| - prefs->GetInteger(prefs::kNetworkPredictionOptions),
|
| - prefs->GetBoolean(prefs::kNetworkPredictionEnabled));
|
| + prefs->GetInteger(prefs::kNetworkPredictionOptions));
|
| }
|
|
|
| } // namespace chrome_browser_net
|
|
|