Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(737)

Issue 516403003: Focus the first input when adding a new Autofill cc or address (Closed)

Created:
6 years, 3 months ago by Evan Stade
Modified:
6 years, 3 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, benquan, arv+watch_chromium.org, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org, Dane Wallinga
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Focus the first input when adding a new Autofill cc or address in chrome://settings It was mentioned that this was desirable behavior for desktop during the UX review for the linked bug. BUG=407209 Committed: https://crrev.com/2fad815bdc0d20b421773667c25e1adc4057e7b0 Cr-Commit-Position: refs/heads/master@{#293040}

Patch Set 1 #

Total comments: 2

Patch Set 2 : new function instead #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -2 lines) Patch
M chrome/browser/resources/options/autofill_edit_address_overlay.js View 1 2 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/autofill_edit_creditcard_overlay.js View 1 2 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/autofill_options.js View 1 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Evan Stade
a lot of reviewers are on vacation. Could you take a look Erik? Thanks.
6 years, 3 months ago (2014-08-30 02:00:14 UTC) #2
arv (Not doing code reviews)
I was also on vacation last week. https://codereview.chromium.org/516403003/diff/1/chrome/browser/resources/options/autofill_edit_address_overlay.js File chrome/browser/resources/options/autofill_edit_address_overlay.js (right): https://codereview.chromium.org/516403003/diff/1/chrome/browser/resources/options/autofill_edit_address_overlay.js#newcode334 chrome/browser/resources/options/autofill_edit_address_overlay.js:334: if (!address) ...
6 years, 3 months ago (2014-09-02 17:01:04 UTC) #3
Evan Stade
https://codereview.chromium.org/516403003/diff/1/chrome/browser/resources/options/autofill_edit_address_overlay.js File chrome/browser/resources/options/autofill_edit_address_overlay.js (right): https://codereview.chromium.org/516403003/diff/1/chrome/browser/resources/options/autofill_edit_address_overlay.js#newcode334 chrome/browser/resources/options/autofill_edit_address_overlay.js:334: if (!address) { On 2014/09/02 17:01:04, arv wrote: > ...
6 years, 3 months ago (2014-09-02 18:41:17 UTC) #4
arv (Not doing code reviews)
LGTM
6 years, 3 months ago (2014-09-02 22:12:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/516403003/20001
6 years, 3 months ago (2014-09-02 22:18:18 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel_swarming on tryserver.chromium.win ...
6 years, 3 months ago (2014-09-02 23:22:38 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 6137ebf8013103ce109e286a9cc33666fe8a5d90
6 years, 3 months ago (2014-09-03 01:27:33 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:22:33 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2fad815bdc0d20b421773667c25e1adc4057e7b0
Cr-Commit-Position: refs/heads/master@{#293040}

Powered by Google App Engine
This is Rietveld 408576698