Refactor captive portal code from SSLBlockingPage to SSLErrorClassification

Refactor captive portal code from SSLBlockingPage to SSLErrorClassification

A function is also added to check the type of the network the user is
connected to.

CL originally written by radhikabhar@ as 400323002, but not landed before
her internship ended.

BUG=395295
TBR=meacer@chromium.org, dcheng@chromium.org

Committed: https://crrev.com/a3b92cfcbaedcb91cf7d70cccdb14894dfc54c96
Cr-Commit-Position: refs/heads/master@{#292767}

[felt, 2014-08-29 23:21:10]

felt@chromium.org changed reviewers:
+ dcheng@chromium.org, meacer@chromium.org

[felt, 2014-08-29 23:21:35]

felt@chromium.org changed reviewers:
+ palmer@chromium.org

[felt, 2014-08-29 23:23:17]

Radhika wasn't able to land her CL (https://codereview.chromium.org/400323002)
before leaving, so I've picked it up again to finish it.

meacer@ and dcheng@, I've TBRed you since you LGTM'ed Radhika's CL already.

palmer@: I made a small change to her CL to fix a bug (web_contents_ was going
away in the destructor); you can see that change in PS3. Can you please review
the change?

[palmer, 2014-08-30 00:28:19]

LGTM with some nits and a question.

https://codereview.chromium.org/516373003/diff/40001/chrome/browser/ssl/ssl_b...
File chrome/browser/ssl/ssl_blocking_page.cc (right):

https://codereview.chromium.org/516373003/diff/40001/chrome/browser/ssl/ssl_b...
chrome/browser/ssl/ssl_blocking_page.cc:379: case
SSLErrorInfo::CERT_DATE_INVALID: {
Nit: These case blocks don't need { } because no new identifiers are declared in
them.

https://codereview.chromium.org/516373003/diff/40001/chrome/browser/ssl/ssl_e...
File chrome/browser/ssl/ssl_error_classification.cc (right):

https://codereview.chromium.org/516373003/diff/40001/chrome/browser/ssl/ssl_e...
chrome/browser/ssl/ssl_error_classification.cc:210: // TODO(radhikabhar): Record
the severity score in a histogram. This will be
TODO(felt) or TODO(palmer), now

https://codereview.chromium.org/516373003/diff/40001/chrome/browser/ssl/ssl_e...
chrome/browser/ssl/ssl_error_classification.cc:249: // TODO(radhikabhar): Record
the severity score in a histogram. Same as above
same

https://codereview.chromium.org/516373003/diff/40001/chrome/browser/ssl/ssl_e...
File chrome/browser/ssl/ssl_error_classification.h (right):

https://codereview.chromium.org/516373003/diff/40001/chrome/browser/ssl/ssl_e...
chrome/browser/ssl/ssl_error_classification.h:34: virtual
~SSLErrorClassification();
Why virtual?

[felt, 2014-08-30 01:11:52]

https://codereview.chromium.org/516373003/diff/40001/chrome/browser/ssl/ssl_b...
File chrome/browser/ssl/ssl_blocking_page.cc (right):

https://codereview.chromium.org/516373003/diff/40001/chrome/browser/ssl/ssl_b...
chrome/browser/ssl/ssl_blocking_page.cc:379: case
SSLErrorInfo::CERT_DATE_INVALID: {
On 2014/08/30 00:28:19, Chromium Palmer wrote:
> Nit: These case blocks don't need { } because no new identifiers are declared
in
> them.

Done.

https://codereview.chromium.org/516373003/diff/40001/chrome/browser/ssl/ssl_e...
File chrome/browser/ssl/ssl_error_classification.cc (right):

https://codereview.chromium.org/516373003/diff/40001/chrome/browser/ssl/ssl_e...
chrome/browser/ssl/ssl_error_classification.cc:210: // TODO(radhikabhar): Record
the severity score in a histogram. This will be
On 2014/08/30 00:28:19, Chromium Palmer wrote:
> TODO(felt) or TODO(palmer), now

Done.

https://codereview.chromium.org/516373003/diff/40001/chrome/browser/ssl/ssl_e...
chrome/browser/ssl/ssl_error_classification.cc:249: // TODO(radhikabhar): Record
the severity score in a histogram. Same as above
On 2014/08/30 00:28:19, Chromium Palmer wrote:
> same

Done.

https://codereview.chromium.org/516373003/diff/40001/chrome/browser/ssl/ssl_e...
File chrome/browser/ssl/ssl_error_classification.h (right):

https://codereview.chromium.org/516373003/diff/40001/chrome/browser/ssl/ssl_e...
chrome/browser/ssl/ssl_error_classification.h:34: virtual
~SSLErrorClassification();
On 2014/08/30 00:28:19, Chromium Palmer wrote:
> Why virtual?

I believe this should be virtual because the Observe method is virtual.

[felt, 2014-08-30 01:12:04]

The CQ bit was checked by felt@chromium.org

[commit-bot: I haz the power, 2014-08-30 01:13:44]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/felt@chromium.org/516373003/60001

[commit-bot: I haz the power, 2014-08-30 02:05:48]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[felt, 2014-08-30 02:12:02]

The CQ bit was checked by felt@chromium.org

[commit-bot: I haz the power, 2014-08-30 02:12:37]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/felt@chromium.org/516373003/80001

[commit-bot: I haz the power, 2014-08-30 03:10:09]

Committed patchset #5 (id:80001) as 5bc4a0f302992545e73afc077cad417de31aaae5

[commit-bot: I haz the power, 2014-09-10 03:13:35]

Patchset 5 (id:??) landed as
https://crrev.com/a3b92cfcbaedcb91cf7d70cccdb14894dfc54c96
Cr-Commit-Position: refs/heads/master@{#292767}