Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(703)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java

Issue 516323003: [Android] JNI bridges for querying top level bookmark folders. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove debug log Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java
index 87b1061f9d94316a33c3bb9a53f7958f5136fa3e..1241fca27e2b3887ee2e890c2ceb690e4ca18a82 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/BookmarksBridge.java
@@ -179,6 +179,31 @@ public class BookmarksBridge {
}
/**
+ * @return The top level folder's parents, which are root node, mobile node, and other node.
+ */
+ public List<BookmarkId> getTopLevelFolderParentIDs() {
+ assert mIsNativeBookmarkModelLoaded;
+ List<BookmarkId> result = new ArrayList<BookmarkId>();
+ nativeGetTopLevelFolderParentIDs(mNativeBookmarksBridge, result);
+ return result;
+ }
+
+ /**
+ * @param getSpecial Whether special top folders should be returned.
+ * @param getNormal Whether normal top folders should be returned.
+ * @return The top level folders. Note that normal top folders will be in the alphabetical
newt (away) 2014/09/02 19:00:10 do the special folders come before or after the no
Kibeom Kim (inactive) 2014/09/03 00:06:27 Done. (before)
+ * order. Special top folders are managed bookmark root folder and partner bookmark
newt (away) 2014/09/02 19:00:10 remove "root" and "folder root folder"
Kibeom Kim (inactive) 2014/09/03 00:06:27 Done.
+ * folder root folder. Normal top folders are desktop permanent folder, and the
+ * sub-folders of mobile permanent folder and others permanent folder.
+ */
+ public List<BookmarkId> getTopLevelFolderIDs(boolean getSpecial, boolean getNormal) {
+ assert mIsNativeBookmarkModelLoaded;
+ List<BookmarkId> result = new ArrayList<BookmarkId>();
+ nativeGetTopLevelFolderIDs(mNativeBookmarksBridge, getSpecial, getNormal, result);
+ return result;
+ }
+
+ /**
* Reads sub-folder IDs, sub-bookmark IDs, or both of the given folder.
*
* @param getFolders Whether sub-folders should be returned.
@@ -413,6 +438,10 @@ public class BookmarksBridge {
int type);
private native void nativeGetPermanentNodeIDs(long nativeBookmarksBridge,
List<BookmarkId> bookmarksList);
+ private native void nativeGetTopLevelFolderParentIDs(long nativeBookmarksBridge,
+ List<BookmarkId> bookmarksList);
+ private native void nativeGetTopLevelFolderIDs(long nativeBookmarksBridge, boolean getSpecial,
+ boolean getNormal, List<BookmarkId> bookmarksList);
private native void nativeGetChildIDs(long nativeBookmarksBridge, long id, int type,
boolean getFolders, boolean getBookmarks, List<BookmarkId> bookmarksList);
private native void nativeGetAllBookmarkIDsOrderedByCreationDate(long nativeBookmarksBridge,

Powered by Google App Engine
This is Rietveld 408576698