extensions/common/extension.h - Issue 516293007: Enable forced extension updates on NaCl arch mismatch

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/extension.h

Issue 516293007: Enable forced extension updates on NaCl arch mismatch (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Clean-up per discussed solution Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/updater/manifest_fetch_data.cc ('K') | « chrome/browser/extensions/updater/manifest_fetch_data.cc ('k') | extensions/common/extension.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/extension.h

diff --git a/extensions/common/extension.h b/extensions/common/extension.h

index 668f52f6806af108db2709416e594fd601467675..067ff0ffb42700cf5cabc89dafc6918178323980 100644

--- a/extensions/common/extension.h

+++ b/extensions/common/extension.h

@@ -351,6 +351,9 @@ class Extension : public base::RefCountedThreadSafe<Extension> {

void AddWebExtentPattern(const URLPattern& pattern);

const URLPatternSet& web_extent() const { return extent_; }

+ bool HasPlatformSpecificResources() const;

+ bool HasResourcesForPlatform(const std::string& nacl_arch) const;

private:

friend class base::RefCountedThreadSafe<Extension>;

@@ -480,6 +483,10 @@ class Extension : public base::RefCountedThreadSafe<Extension> {

// The flags that were passed to InitFromValue.

int creation_flags_;

+ // The set of NaCl archs for which platform-specific resources exist in this

+ // extension, if any.

+ std::set<std::string> installed_nacl_archs_;

DISALLOW_COPY_AND_ASSIGN(Extension);

};