Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Unified Diff: chrome/browser/extensions/updater/manifest_fetch_data.h

Issue 516293007: Enable forced extension updates on NaCl arch mismatch (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Clean-up per discussed solution Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/updater/manifest_fetch_data.h
diff --git a/chrome/browser/extensions/updater/manifest_fetch_data.h b/chrome/browser/extensions/updater/manifest_fetch_data.h
index a7eab99fd290a0691fc9cfebe6c59b004b7cedf6..8a42fc95dc02ba094ff2382b2dcaa6bea9adb09c 100644
--- a/chrome/browser/extensions/updater/manifest_fetch_data.h
+++ b/chrome/browser/extensions/updater/manifest_fetch_data.h
@@ -56,7 +56,8 @@ class ManifestFetchData {
const std::string& version,
const PingData* ping_data,
const std::string& update_url_data,
- const std::string& install_source);
+ const std::string& install_source,
+ bool force_update);
const GURL& base_url() const { return base_url_; }
const GURL& full_url() const { return full_url_; }
@@ -76,6 +77,9 @@ class ManifestFetchData {
// to this ManifestFetchData).
void Merge(const ManifestFetchData& other);
+ // Indiciates whether or not a given extension ID was forced to update.
Sorin Jianu 2014/09/02 20:06:39 Indicates. Or rephrase to "Returns true if a give
Ken Rockot(use gerrit already) 2014/09/02 20:19:20 Done.
+ bool DidForceUpdate(const std::string& extension_id) const;
+
private:
// The set of extension id's for this ManifestFetchData.
std::set<std::string> extension_ids_;
@@ -96,6 +100,8 @@ class ManifestFetchData {
// one ManifestFetchData.
std::set<int> request_ids_;
Sorin Jianu 2014/09/02 20:06:39 Comment? The other private members have comments.
Ken Rockot(use gerrit already) 2014/09/02 20:19:20 Done.
+ std::set<std::string> forced_updates_;
+
DISALLOW_COPY_AND_ASSIGN(ManifestFetchData);
};

Powered by Google App Engine
This is Rietveld 408576698