Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 516293003: Sort jarjar resource list for makefile stability. (Closed)

Created:
6 years, 3 months ago by Torne
Modified:
6 years, 3 months ago
Reviewers:
benm (inactive)
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Sort jarjar resource list for makefile stability. Sort the list of input resource files for the jarjar resource step so that the contents of generated makefiles in WebView have a stable ordering. BUG= Committed: https://crrev.com/c7cee69c4ae1b6b41564a92378ef6c8a92a57174 Cr-Commit-Position: refs/heads/master@{#292671}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M android_webview/build/jarjar_resources.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Torne
6 years, 3 months ago (2014-08-29 17:20:19 UTC) #2
benm (inactive)
lgtm
6 years, 3 months ago (2014-08-29 17:21:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/torne@chromium.org/516293003/1
6 years, 3 months ago (2014-08-29 17:27:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 05e63bf88f2584f971279104f72b0e9b9e1d9071
6 years, 3 months ago (2014-08-29 18:41:13 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:10:10 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c7cee69c4ae1b6b41564a92378ef6c8a92a57174
Cr-Commit-Position: refs/heads/master@{#292671}

Powered by Google App Engine
This is Rietveld 408576698