Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 516283004: Do not access an invalidated reference in media::WebMListParser::OnListEnd(). (Closed)

Created:
6 years, 3 months ago by earthdok
Modified:
6 years, 3 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Do not access an invalidated reference in media::WebMListParser::OnListEnd(). This was detected by ASan's new container-overflow feature. BUG=409051 R=acolwell@chromium.org Committed: https://crrev.com/96ec01dcfbb16c1cc2240a24001482217ae241f6 Cr-Commit-Position: refs/heads/master@{#292674}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M media/formats/webm/webm_parser.cc View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
earthdok
please take a look
6 years, 3 months ago (2014-08-29 16:51:58 UTC) #1
acolwell GONE FROM CHROMIUM
lgtm
6 years, 3 months ago (2014-08-29 17:52:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/earthdok@chromium.org/516283004/1
6 years, 3 months ago (2014-08-29 17:55:34 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as ce1bc5b4ef610ff0112075e923646b5d1bdfd69c
6 years, 3 months ago (2014-08-29 18:57:16 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:10:16 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/96ec01dcfbb16c1cc2240a24001482217ae241f6
Cr-Commit-Position: refs/heads/master@{#292674}

Powered by Google App Engine
This is Rietveld 408576698