Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1238)

Unified Diff: Source/core/html/shadow/PluginPlaceholderElement.js

Issue 516273002: Move plugin placeholder style to CSS, and allow it to bypass main world CSP. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: remove excess inline style from js Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/dom/StyleElement.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/shadow/PluginPlaceholderElement.js
diff --git a/Source/core/html/shadow/PluginPlaceholderElement.js b/Source/core/html/shadow/PluginPlaceholderElement.js
index 9d3ef2b37aa6d94de92edf79cf46ab0b0f2843c1..21cc3b782cc90ab99789d7c5ec5706f130f89255 100644
--- a/Source/core/html/shadow/PluginPlaceholderElement.js
+++ b/Source/core/html/shadow/PluginPlaceholderElement.js
@@ -5,27 +5,36 @@
'use strict';
installClass('PluginPlaceholderElement', function(PluginPlaceholderElementPrototype) {
- PluginPlaceholderElementPrototype.createdCallback = function() {
- // FIXME: Move style out of script and into CSS.
+ // FIXME: Load this from a .css file.
+ var styleSource =
+ '#plugin-placeholder {' +
+ ' width: 100%;' +
+ ' height: 100%;' +
+ ' overflow: hidden;' +
+ ' display: flex;' +
+ ' align-items: center;' +
+ ' background: gray;' +
+ ' font: 12px -webkit-control;' +
+ '}' +
+ '#plugin-placeholder-content {' +
+ ' text-align: center;' +
+ ' margin: auto;' +
+ '}';
+ PluginPlaceholderElementPrototype.createdCallback = function() {
this.id = 'plugin-placeholder';
- this.style.width = '100%';
- this.style.height = '100%';
- this.style.overflow = 'hidden';
- this.style.display = 'flex';
- this.style.alignItems = 'center';
- this.style.backgroundColor = 'gray';
- this.style.font = '12px -webkit-control';
+
+ var styleElement = document.createElement('style');
+ styleElement.textContent = styleSource;
var contentElement = document.createElement('div');
contentElement.id = 'plugin-placeholder-content';
- contentElement.style.textAlign = 'center';
- contentElement.style.margin = 'auto';
var messageElement = document.createElement('div');
messageElement.id = 'plugin-placeholder-message';
contentElement.appendChild(messageElement);
+ this.appendChild(styleElement);
this.appendChild(contentElement);
this.messageElement = messageElement;
« no previous file with comments | « Source/core/dom/StyleElement.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698