Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(987)

Issue 516253002: MIPS: Refactoring InterfaceDescriptors away from code-stubs.h - external. (Closed)

Created:
6 years, 3 months ago by balazs.kilvady
Modified:
6 years, 3 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

MIPS: Refactoring InterfaceDescriptors away from code-stubs.h - external. Port r23515 (fe0bdbf) Original commit message: Clean up and create seperation between the concept of a call descriptor and a code stub interface descriptor. The former is just concerned with how to call, but the latter has many extra hints related to code generation and deoptimization for the implementation of a particular code stub. BUG= R=paul.lind@imgtec.com, vogelheim@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23525

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
balazs.kilvady
balazs.kilvady@imgtec.com changed reviewers: + akos.palfi@imgtec.com, danno@chromium.org, dusan.milosavljevic@imgtec.com, gergely.kis@imgtec.com, mvstanton@chromium.org, paul.lind@imgtec.com
6 years, 3 months ago (2014-08-29 15:08:07 UTC) #1
balazs.kilvady
PTAL. Could a v8 team member review?
6 years, 3 months ago (2014-08-29 15:10:57 UTC) #2
paul.l...
paul.lind@imgtec.com changed reviewers: + vogelheim@chromium.org
6 years, 3 months ago (2014-08-29 15:16:00 UTC) #3
paul.l...
Obviously, this is just the arch-independent parts that need v8 team approval. The meat of ...
6 years, 3 months ago (2014-08-29 15:16:01 UTC) #4
vogelheim
lgtm I'll take it you'll submit this right after the change which introduces the corresponding ...
6 years, 3 months ago (2014-08-29 15:25:37 UTC) #5
balazs.kilvady
Committed patchset #1 manually as r23525.
6 years, 3 months ago (2014-08-29 15:28:33 UTC) #6
paul.l...
6 years, 3 months ago (2014-08-29 15:34:40 UTC) #7
Message was sent while issue was closed.
On 2014/08/29 15:25:37, vogelheim wrote:
> I'll take it you'll submit this right after the change which introduces the
> corresponding sources?

Yes (in fact, the other cl did just land.) The idea is to have a precedent that
build or other arch-independent changes can get approved early for MIPS, while
your team is still in the office. We can then take as long as needed on the
rest, and still get them in same day, for testing & auto-rolls. We will not land
these until associated source changes land, per your request.

Powered by Google App Engine
This is Rietveld 408576698