ui: Replace MessageLoopProxy usage with ThreadTaskRunnerHandle.

ui: Replace MessageLoopProxy usage with ThreadTaskRunnerHandle.

MessageLoopProxy is deprecated.

This basically does a search and replace:

MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get().

BUG=391045
TEST=unittests
R=sky@chromium.org

Committed: https://crrev.com/57d2a7e1ea1130c451626f66e8cc545aef41be92
Cr-Commit-Position: refs/heads/master@{#293157}

[sky, 2014-09-02 15:34:14]

https://codereview.chromium.org/516173002/diff/1/ui/app_list/views/top_icon_a...
File ui/app_list/views/top_icon_animation_view.cc (right):

https://codereview.chromium.org/516173002/diff/1/ui/app_list/views/top_icon_a...
ui/app_list/views/top_icon_animation_view.cc:87:
base::ThreadTaskRunnerHandle::Get()->DeleteSoon(FROM_HERE, this);
This can be MessageLoop::current().

https://codereview.chromium.org/516173002/diff/1/ui/events/test/event_generat...
File ui/events/test/event_generator.cc (right):

https://codereview.chromium.org/516173002/diff/1/ui/events/test/event_generat...
ui/events/test/event_generator.cc:593:
base::ThreadTaskRunnerHandle::Get()->PostTask(
ML::current()->

https://codereview.chromium.org/516173002/diff/1/ui/events/test/event_generat...
ui/events/test/event_generator.cc:615:
base::ThreadTaskRunnerHandle::Get()->PostTask(
ML::current()->

[Ryan Sleevi, 2014-09-02 15:37:21]

On 2014/09/02 15:34:14, sky wrote:
>
https://codereview.chromium.org/516173002/diff/1/ui/app_list/views/top_icon_a...
> File ui/app_list/views/top_icon_animation_view.cc (right):
> 
>
https://codereview.chromium.org/516173002/diff/1/ui/app_list/views/top_icon_a...
> ui/app_list/views/top_icon_animation_view.cc:87:
> base::ThreadTaskRunnerHandle::Get()->DeleteSoon(FROM_HERE, this);
> This can be MessageLoop::current().
> 
>
https://codereview.chromium.org/516173002/diff/1/ui/events/test/event_generat...
> File ui/events/test/event_generator.cc (right):
> 
>
https://codereview.chromium.org/516173002/diff/1/ui/events/test/event_generat...
> ui/events/test/event_generator.cc:593:
> base::ThreadTaskRunnerHandle::Get()->PostTask(
> ML::current()->
> 
>
https://codereview.chromium.org/516173002/diff/1/ui/events/test/event_generat...
> ui/events/test/event_generator.cc:615:
> base::ThreadTaskRunnerHandle::Get()->PostTask(
> ML::current()->

TTRH::Get is preferred over ML::current as well :)

[sky, 2014-09-02 18:03:12]

Why is that? From looking ML::current() isn't deprecated. IMO
::current() is a clearer name then ::Get for something that varies
depending upon the thread.

On Tue, Sep 2, 2014 at 8:37 AM,  <rsleevi@chromium.org> wrote:
> On 2014/09/02 15:34:14, sky wrote:
>
>
https://codereview.chromium.org/516173002/diff/1/ui/app_list/views/top_icon_a...
>>
>> File ui/app_list/views/top_icon_animation_view.cc (right):
>
>
>
>
https://codereview.chromium.org/516173002/diff/1/ui/app_list/views/top_icon_a...
>>
>> ui/app_list/views/top_icon_animation_view.cc:87:
>> base::ThreadTaskRunnerHandle::Get()->DeleteSoon(FROM_HERE, this);
>> This can be MessageLoop::current().
>
>
>
>
https://codereview.chromium.org/516173002/diff/1/ui/events/test/event_generat...
>>
>> File ui/events/test/event_generator.cc (right):
>
>
>
>
https://codereview.chromium.org/516173002/diff/1/ui/events/test/event_generat...
>>
>> ui/events/test/event_generator.cc:593:
>> base::ThreadTaskRunnerHandle::Get()->PostTask(
>> ML::current()->
>
>
>
>
https://codereview.chromium.org/516173002/diff/1/ui/events/test/event_generat...
>>
>> ui/events/test/event_generator.cc:615:
>> base::ThreadTaskRunnerHandle::Get()->PostTask(
>> ML::current()->
>
>
> TTRH::Get is preferred over ML::current as well :)
>
> https://codereview.chromium.org/516173002/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Ryan Sleevi, 2014-09-02 23:58:00]

On 2014/09/02 18:03:12, sky wrote:
> Why is that? From looking ML::current() isn't deprecated. IMO
> ::current() is a clearer name then ::Get for something that varies
> depending upon the thread.

ML::current() assumes a MessageLoop, but MessageLoop itself as a 'public' API
concept is deprecated in favour of TaskRunner.

There's a growing body of code that now uses a TaskRunner interface for the
thread, but has no MessageLoop (in particular, Pepper plugins, which use a
TaskRunner wrapped around Pepper's message pump)

Anything that relies on MessageLoop(Proxy) as a public interface (e.g. outside
of //base) is better in using the //base-level concept of a TaskRunner,
including the "Task runner for the current thread" (which will return the
correct thing for worker threads, pepper threads, etc)

[Ryan Sleevi, 2014-09-02 23:58:55]

rsleevi@chromium.org changed reviewers:
+ rsleevi@chromium.org

[Ryan Sleevi, 2014-09-02 23:58:56]

not an owner, but this all LG to me

[sky, 2014-09-03 14:46:30]

Ok, LGTM

[tfarina, 2014-09-03 16:24:13]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2014-09-03 16:31:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tfarina@chromium.org/516173002/1

[commit-bot: I haz the power, 2014-09-03 17:04:59]

Committed patchset #1 (id:1) as 2b4cb020caf4ac6e2f5fbf4896916f1a18bde0c0

[commit-bot: I haz the power, 2014-09-10 03:26:25]

Patchset 1 (id:??) landed as
https://crrev.com/57d2a7e1ea1130c451626f66e8cc545aef41be92
Cr-Commit-Position: refs/heads/master@{#293157}