Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 516163003: Fix UI glitches in the new avatar bubble (Closed)

Created:
6 years, 3 months ago by guohui
Modified:
6 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix UI glitches in the new avatar bubble 1. the ruler lines in the "not claire" view on mac is not full width. 2. the title cards on windows has extra padding at the top. BUG=406618 Committed: https://crrev.com/7cd720bd294794b47e82ef72b86d53d6d482b86d Cr-Commit-Position: refs/heads/master@{#292967}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -13 lines) Patch
M chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm View 8 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/profiles/profile_chooser_view.cc View 3 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
guohui
guohui@chromium.org changed reviewers: + sky@chromium.org
6 years, 3 months ago (2014-08-29 13:56:36 UTC) #1
guohui
Hey, could you please review the CL? Thanks, Hui
6 years, 3 months ago (2014-08-29 13:56:36 UTC) #2
guohui
ping?
6 years, 3 months ago (2014-08-30 01:22:42 UTC) #3
sky
LGTM
6 years, 3 months ago (2014-09-02 17:09:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/guohui@chromium.org/516163003/40001
6 years, 3 months ago (2014-09-02 17:21:16 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel_swarming on tryserver.chromium.mac ...
6 years, 3 months ago (2014-09-02 18:17:29 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:40001) as 5e717b33951dec4e34e3474ad0b4b364048d6e37
6 years, 3 months ago (2014-09-02 18:48:02 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:19:44 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7cd720bd294794b47e82ef72b86d53d6d482b86d
Cr-Commit-Position: refs/heads/master@{#292967}

Powered by Google App Engine
This is Rietveld 408576698