Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 516143002: Define WEBRTC_CHROMIUM_BUILD in libjingle.gyp. (Closed)

Created:
6 years, 3 months ago by ajm
Modified:
6 years, 3 months ago
Reviewers:
hellner1, Sergey Ulanov
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Define WEBRTC_CHROMIUM_BUILD in libjingle.gyp. Code under webrtc/ expects this to be defined when building against Chromium. With talk/base having moved to webrtc/base, libjingle code must adopt this expectation. This appears to be the most straightforward way of adding this define. In particular, this is now required to avoid redefinition errors after the addition of CHECK macros to webrtc/base. TESTED=local Linux build against the latest webrtc passes. Committed: https://crrev.com/67fa5e94bdbd9eb7bce39c0cd6922321cf4998c9 Cr-Commit-Position: refs/heads/master@{#292676}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/libjingle/libjingle.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
ajm
ajm@chromium.org changed reviewers: + hellner@chromium.org, sergeyu@chromium.org
6 years, 3 months ago (2014-08-29 01:08:14 UTC) #1
ajm
Henrik: since you know the context. Sergey: owner stamp.
6 years, 3 months ago (2014-08-29 01:08:14 UTC) #2
hellner1
lgtm relevant standalone cl is https://code.google.com/p/webrtc/source/detail?r=7004
6 years, 3 months ago (2014-08-29 15:56:36 UTC) #3
ajm
Thanks. Sergey, could you give this an owner stamp?
6 years, 3 months ago (2014-08-29 16:12:15 UTC) #4
Sergey Ulanov
lgtm
6 years, 3 months ago (2014-08-29 17:36:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ajm@chromium.org/516143002/1
6 years, 3 months ago (2014-08-29 17:46:05 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 51326186c35a523a0ccc2efce3c1b83e885a3fcf
6 years, 3 months ago (2014-08-29 19:03:04 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:10:19 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/67fa5e94bdbd9eb7bce39c0cd6922321cf4998c9
Cr-Commit-Position: refs/heads/master@{#292676}

Powered by Google App Engine
This is Rietveld 408576698