Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2202)

Unified Diff: Source/modules/serviceworkers/Request.cpp

Issue 516123004: Support ServiceWorker created request objects. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@minimaster
Patch Set: improved test Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/serviceworkers/Request.cpp
diff --git a/Source/modules/serviceworkers/Request.cpp b/Source/modules/serviceworkers/Request.cpp
index 835617bc59f83e6a0c5619fdd0ba50d7b1c7f626..bbadc89d2aa9eb0173f57671f05ac7dbf307546f 100644
--- a/Source/modules/serviceworkers/Request.cpp
+++ b/Source/modules/serviceworkers/Request.cpp
@@ -12,6 +12,7 @@
#include "core/loader/ThreadableLoader.h"
#include "core/xml/XMLHttpRequest.h"
#include "modules/serviceworkers/FetchManager.h"
+#include "modules/serviceworkers/HeadersForEachCallback.h"
#include "modules/serviceworkers/RequestInit.h"
#include "platform/NotImplemented.h"
#include "platform/network/HTTPParsers.h"
@@ -23,6 +24,26 @@ namespace blink {
namespace {
+class FillWebRequestHeaders : public HeadersForEachCallback {
+public:
+ FillWebRequestHeaders(WebServiceWorkerRequest* webRequest) : m_webRequest(webRequest) { }
+
+ virtual bool handleItem(ScriptValue, const String&, const String&, Headers*)
+ {
+ ASSERT_NOT_REACHED();
+ return false;
+ }
+
+ virtual bool handleItem(const String& value, const String& key, Headers*)
+ {
+ m_webRequest->setHeader(key, value);
+ return true;
+ }
+
+private:
+ WebServiceWorkerRequest* m_webRequest;
+};
+
PassRefPtrWillBeRawPtr<Request> createRequestWithRequestData(PassRefPtrWillBeRawPtr<FetchRequestData> request, const RequestInit& init, FetchRequestData::Mode mode, FetchRequestData::Credentials credentials, ExceptionState& exceptionState)
{
// "6. Let |mode| be |init|'s mode member if it is present, and
@@ -264,6 +285,16 @@ String Request::credentials() const
return "";
}
+void Request::populateWebServiceWorkerRequest(WebServiceWorkerRequest& webRequest)
+{
+ webRequest.setMethod(method());
+ webRequest.setURL(m_request->url());
+ m_headers->forEach(adoptPtr(new FillWebRequestHeaders(&webRequest)));
+ webRequest.setReferrer(m_request->referrer().referrer().referrer, static_cast<WebReferrerPolicy>(m_request->referrer().referrer().referrerPolicy));
+ // FIXME: How can we set isReload properly? What is the correct place to load it in to the Request object? We should investigate the right way
+ // to plumb this information in to here.
+}
+
void Request::trace(Visitor* visitor)
{
visitor->trace(m_request);

Powered by Google App Engine
This is Rietveld 408576698