Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(805)

Issue 516123002: NaCl: Update revision in DEPS, r13666 -> r13675 (Closed)

Created:
6 years, 3 months ago by Mark Seaborn
Modified:
6 years, 3 months ago
Reviewers:
bradn
CC:
chromium-reviews, dbrazdil, Derek Schuff, Mark Seaborn, native-client-reviews_googlegroups.com, noelallen_use_chromium, Yoshisato Yanagisawa
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

NaCl: Update revision in DEPS, r13666 -> r13675 This pulls in the following Native Client changes: r13667: (yyanagisawa) Re-enable use of Goma on Windows, except when using the PNaCl toolchain r13668: (noelallen) Force rebuild on cmd change. r13669: (dbrazdil) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS r13670: (mseaborn) Fix munmap() with length > 0xffff0000 to behave consistently on 32/64-bit r13671: (mseaborn) Add comment about updating the trybot list in the Commit Queue's code r13672: (dschuff) Expose LLC's -force-align-stack flag to pnacl-translate r13673: (dschuff) PNaCl: Update libc++ revision in pnacl/COMPONENT_REVISIONS r13674: (mseaborn) Use uint32_t for untrusted pointer args: sysconf() and other syscalls r13675: (mseaborn) Revert r13667: "Re-enable use of Goma on Windows, except when using the PNaCl toolchain" BUG=none TEST=browser_tests and nacl_integration CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm_cross_compile,linux_nacl_sdk_build Committed: https://crrev.com/e1e99f7756872cd76a255036c3bcaebfeab050e8 Cr-Commit-Position: refs/heads/master@{#292647}

Patch Set 1 #

Patch Set 2 : Fix rev #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Mark Seaborn
mseaborn@chromium.org changed reviewers: + bradnelson@google.com
6 years, 3 months ago (2014-08-29 00:44:26 UTC) #1
Mark Seaborn
6 years, 3 months ago (2014-08-29 00:44:26 UTC) #2
bradn
lgtm
6 years, 3 months ago (2014-08-29 14:01:21 UTC) #3
Mark Seaborn
The CQ bit was checked by mseaborn@chromium.org
6 years, 3 months ago (2014-08-29 14:16:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mseaborn@chromium.org/516123002/20001
6 years, 3 months ago (2014-08-29 14:17:38 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 1eff26fcc1d71047eb4b39d7ec564b012d7d8a15
6 years, 3 months ago (2014-08-29 16:22:40 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:09:05 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e1e99f7756872cd76a255036c3bcaebfeab050e8
Cr-Commit-Position: refs/heads/master@{#292647}

Powered by Google App Engine
This is Rietveld 408576698