Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 516113002: Remove time getters from AudioBufferQueue and AudioRendererAlgorithm. (Closed)

Created:
6 years, 3 months ago by scherkus (not reviewing)
Modified:
6 years, 3 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove time getters from AudioBufferQueue and AudioRendererAlgorithm. With the switch to pure frame-based calculation of time in 5b6ce11, these methods are no longer used. BUG=370634 Committed: https://crrev.com/50687650f80e74d4135f7002c1c1b30f94892b28 Cr-Commit-Position: refs/heads/master@{#292560}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -170 lines) Patch
M media/base/audio_buffer_queue.h View 3 chunks +0 lines, -15 lines 0 comments Download
M media/base/audio_buffer_queue.cc View 4 chunks +0 lines, -26 lines 0 comments Download
M media/base/audio_buffer_queue_unittest.cc View 1 chunk +0 lines, -121 lines 0 comments Download
M media/filters/audio_renderer_algorithm.h View 1 chunk +0 lines, -4 lines 0 comments Download
M media/filters/audio_renderer_algorithm.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
scherkus (not reviewing)
scherkus@chromium.org changed reviewers: + dalecurtis@chromium.org
6 years, 3 months ago (2014-08-29 00:01:05 UTC) #1
scherkus (not reviewing)
6 years, 3 months ago (2014-08-29 00:01:06 UTC) #2
DaleCurtis
lgtm \o/
6 years, 3 months ago (2014-08-29 00:12:38 UTC) #3
scherkus (not reviewing)
The CQ bit was checked by scherkus@chromium.org
6 years, 3 months ago (2014-08-29 00:22:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/516113002/1
6 years, 3 months ago (2014-08-29 00:24:44 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel_swarming on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-29 02:06:23 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-29 02:14:13 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/11285)
6 years, 3 months ago (2014-08-29 02:14:14 UTC) #8
scherkus (not reviewing)
The CQ bit was checked by scherkus@chromium.org
6 years, 3 months ago (2014-08-29 02:17:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/516113002/1
6 years, 3 months ago (2014-08-29 02:18:58 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as d52688562228ca818cb838d3dceb0ad2d99cab74
6 years, 3 months ago (2014-08-29 02:57:49 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:05:49 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/50687650f80e74d4135f7002c1c1b30f94892b28
Cr-Commit-Position: refs/heads/master@{#292560}

Powered by Google App Engine
This is Rietveld 408576698