Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 516083002: Fix and re-enable the Feedback API Test. (Closed)

Created:
6 years, 3 months ago by rkc
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix and re-enable the Feedback API Test. This test should now be working after the fixes to the screenshotting code that initialy had made it fail. Also adding an OWNERS file for the Feedback API directory. R=kalman@chromium.org BUG=369886 Committed: https://crrev.com/1f3c21e7e01398664ca92291b16e4c9fa05a0dd3 Cr-Commit-Position: refs/heads/master@{#292547}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
A + chrome/browser/extensions/api/feedback_private/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/extensions/api/feedback_private/feedback_private_apitest.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/feedback_private/basic/test.js View 1 2 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
rkc
6 years, 3 months ago (2014-08-28 22:12:30 UTC) #1
not at google - send to devlin
lgtm https://codereview.chromium.org/516083002/diff/20001/chrome/test/data/extensions/api_test/feedback_private/basic/test.js File chrome/test/data/extensions/api_test/feedback_private/basic/test.js (right): https://codereview.chromium.org/516083002/diff/20001/chrome/test/data/extensions/api_test/feedback_private/basic/test.js#newcode24 chrome/test/data/extensions/api_test/feedback_private/basic/test.js:24: var feedbackInfo = {}; feedbackInfo = { description: ...
6 years, 3 months ago (2014-08-28 22:45:52 UTC) #2
rkc
https://codereview.chromium.org/516083002/diff/20001/chrome/test/data/extensions/api_test/feedback_private/basic/test.js File chrome/test/data/extensions/api_test/feedback_private/basic/test.js (right): https://codereview.chromium.org/516083002/diff/20001/chrome/test/data/extensions/api_test/feedback_private/basic/test.js#newcode24 chrome/test/data/extensions/api_test/feedback_private/basic/test.js:24: var feedbackInfo = {}; On 2014/08/28 22:45:51, kalman wrote: ...
6 years, 3 months ago (2014-08-28 23:31:18 UTC) #3
rkc
The CQ bit was checked by rkc@chromium.org
6 years, 3 months ago (2014-08-28 23:31:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/516083002/40001
6 years, 3 months ago (2014-08-28 23:32:36 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel_swarming on tryserver.chromium.win ...
6 years, 3 months ago (2014-08-29 00:50:49 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 9980f867e5f640ca1e44ca9fe9de8bf20a8d2e09
6 years, 3 months ago (2014-08-29 02:02:57 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:05:13 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1f3c21e7e01398664ca92291b16e4c9fa05a0dd3
Cr-Commit-Position: refs/heads/master@{#292547}

Powered by Google App Engine
This is Rietveld 408576698