Minimalistic analytics library used by Dart Server and try.dartlang.org

dart/pkg/microlytics/lib/channels.dart

Index: dart/pkg/microlytics/lib/channels.dart
diff --git a/dart/pkg/microlytics/lib/channels.dart b/dart/pkg/microlytics/lib/channels.dart
new file mode 100644
index 0000000000000000000000000000000000000000..9dd3fe8ca34639901bc78e64369982a2805e1af1
--- /dev/null
+++ b/dart/pkg/microlytics/lib/channels.dart
@@ -0,0 +1,55 @@
+// Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+library microlytics.channels;
+
+import 'dart:async';
+
+const String ANALYTICS_URL = "https://ssl.google-analytics.com/collect";

[ahe, 2014/09/05 07:51:36]

Sorry, I know I suggested using ssl. here, but then I read something else on
Google Analytics site that led me to believe it is now deprecated. 

+
+abstract class Channel {
+  void sendData(String data);
+  void shutdown() {}
+}
+
+/// [Channel] that implements a leaky bucket
+/// algorithm to provide rate limiting.
+/// See [http://en.wikipedia.org/wiki/Leaky_bucket].

[ahe, 2014/09/05 07:51:36]

Just a thought. You might want to consider this algorithm's impact on battery
usage.

+class RateLimitingBufferedChannel extends Channel {
+  final List<String> _buffer = <String>[];

[ahe, 2014/09/05 07:51:36]

Wouldn't a Queue be a better fit?

+  final Channel _innerChannel;
+  final int _bufferSizeLimit;
+  Timer _timer;
+
+  RateLimitingBufferedChannel(
+      this._innerChannel,
+      {int bufferSizeLimit: 10,
+        double packetsPerSecond: 1.0})
+      : this._bufferSizeLimit = bufferSizeLimit {
+    if (!(packetsPerSecond > 0)) {
+      throw new ArgumentError("packetsPerSecond must be larger than zero");

[ahe, 2014/09/05 07:51:36]

Not a proper sentence (no period).

+    }
+
+    int transmitDelay = (1000 / packetsPerSecond).floor();
+    _timer = new Timer.periodic(new Duration(milliseconds: transmitDelay),
+        (_) => _onTimerTick() );

[ahe, 2014/09/05 07:51:36]

Weird formatting, and extra space between ) ).

Suggest this formatting:

    _timer = new Timer.periodic(
        new Duration(milliseconds: transmitDelay), _onTimerTick);

(Add ignored argument to _onTimerTick).

+  }
+
+  void _onTimerTick() {
+    if (_buffer.length > 0) {
+      String item = _buffer.removeLast();
+      _innerChannel.sendData(item);
+    }
+  }
+
+  void sendData(String data) {
+    if (_buffer.length >= _bufferSizeLimit) return;
+    _buffer.add(data);
+  }
+
+  void shutdown() {
+    _timer.cancel();
+    _innerChannel.shutdown();
+  }
+}