Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Side by Side Diff: dart_microlytics/lib/io_channels.dart

Issue 515993003: Minimalistic analytics library used by Dart Server and try.dartlang.org (Closed) Base URL: https://github.com/lukechurch/dart-mircolytics.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file.
ahe 2014/09/02 13:44:24 Add line between copyright and library declaration
lukechurch 2014/09/02 19:52:37 Done.
4 library microlytics.io_channels;
5
6 import 'dart:io';
7 import 'channels.dart';
8
9 final String _ANALYTICS_URL = "https://www.google-analytics.com/collect";
ahe 2014/09/02 13:44:24 Can you share these constants to avoid defining th
lukechurch 2014/09/02 19:52:37 Done. I wanted to do this, but it breaks the _priv
10
11 class HttpClientChannel extends Channel {
12 void sendData(String data) {
13 HttpClient client = new HttpClient();
14 client.postUrl(Uri.parse(_ANALYTICS_URL)).then((HttpClientRequest req) {
15 req.write(data);
16 return req.close();
17 }).then((HttpClientResponse response) {
18 print(response.statusCode);
ahe 2014/09/02 13:44:24 Debug code?
lukechurch 2014/09/02 19:52:37 /red face. Done.
19 response.drain();
20 });
21
ahe 2014/09/02 13:44:24 Remove extra line.
lukechurch 2014/09/02 19:52:37 Done.
22 }
23 }
24
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698