Minimalistic analytics library used by Dart Server and try.dartlang.org

dart_microlytics/lib/html_channels.dart

+// Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.

[ahe, 2014/09/02 13:44:24]

Add line between copyright and library declaration.

[lukechurch, 2014/09/02 19:52:37]

Done.

+library microlytics.html_channels;
+
+import 'dart:html';
+import 'channels.dart';
+
+final String _ANALYTICS_URL = "https://www.google-analytics.com/collect";

[ahe, 2014/09/02 13:44:23]

Would "//www.google-analytics.com/collect" work here?

It works in HTML, I don't know if it works in HttpRequest.

[ahe, 2014/09/02 13:44:23]

In Dart, constants are "const".

[lukechurch, 2014/09/02 19:52:37]

Does that mandate SSL?

Given that I don't know what it does, I'd suggest keeping as is. Any particular
reason you's suggest the above?

[ahe, 2014/09/03 08:51:31]

Yes, if the page uses SSL.
Because I use this trick elsewhere in index.html in Try Dart.

However, I looked at the analytics code in Try Dart. It looks like you're
supposed to use https://ssl.google-analytics.com/, not
https://www.google-analytics.com/.

[lukechurch, 2014/09/03 11:27:16]

Done.

+
+class HttpRequestChannel extends Channel {
+  void sendData(String data) {
+    HttpRequest.request(_ANALYTICS_URL, method: "POST", sendData: data)
+      .then((HttpRequest rest) { }

[ahe, 2014/09/02 13:44:23]

There is no reason to install a then block when you don't intend to react to the
result.

[lukechurch, 2014/09/02 19:52:37]

I thought that there was an issue similar to the one mentioned in 
https://api.dartlang.org/apidocs/channels/stable/dartdoc-viewer/dart:io.HttpC...

I was incorrect. Removing.

+    );
+  }
+}