Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 515983005: Roll pdfium. (Closed)

Created:
6 years, 3 months ago by Tom Sepez
Modified:
6 years, 3 months ago
Reviewers:
Bo Xu, Nico, jun_fang, inferno
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Roll pdfium. This brings in: f105b19 No need to release resources in destructor of CPDF_ShadingObject fdcc874 Restrict index not be greater than row_size in TIFF_PredictLine 405478d Use valid bpc value in LoadPalette() and ContinueToLoadMask() a67da71 Fix a bug when looping through m_pCompData 96f8786 Bounds check before fixed-size memcmp() in CJPX_Decoder::Init(). TBR=thakis@chromium.org Committed: https://crrev.com/1eabd4926acd4db7012b30adf3d6b48dca774680 Cr-Commit-Position: refs/heads/master@{#292502}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
Tom Sepez
tsepez@chromium.org changed reviewers: + bo_xu@foxitsoftware.com, inferno@chromium.org, jun_fang@foxitsoftware.com
6 years, 3 months ago (2014-08-28 21:04:19 UTC) #1
Tom Sepez
The CQ bit was checked by tsepez@chromium.org
6 years, 3 months ago (2014-08-28 21:05:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/515983005/1
6 years, 3 months ago (2014-08-28 21:06:17 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-28 21:06:18 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 3 months ago (2014-08-28 21:06:19 UTC) #5
inferno
The CQ bit was checked by inferno@chromium.org
6 years, 3 months ago (2014-08-28 21:06:53 UTC) #6
inferno
lgtm
6 years, 3 months ago (2014-08-28 21:06:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/515983005/1
6 years, 3 months ago (2014-08-28 21:08:16 UTC) #8
Tom Sepez
tsepez@chromium.org changed reviewers: + thakis@chromium.org
6 years, 3 months ago (2014-08-28 21:08:22 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel_swarming on tryserver.chromium.mac ...
6 years, 3 months ago (2014-08-28 22:29:36 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as 63a8fb99bbd1797efb02e8718363ff1a6602353a
6 years, 3 months ago (2014-08-28 23:42:47 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:03:42 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1eabd4926acd4db7012b30adf3d6b48dca774680
Cr-Commit-Position: refs/heads/master@{#292502}

Powered by Google App Engine
This is Rietveld 408576698