Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 515973003: Fixed problem with incorrect use of $HOME (breaking multi user ChromeOS) (Closed)

Created:
6 years, 3 months ago by Mr4D (OOO till 08-26)
Modified:
6 years, 3 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fixed problem with incorrect use of $HOME (breaking multi user ChromeOS) BUG=355227 TEST=visual Committed: https://crrev.com/66e0255cea8ef64f16cc74b9579c1c37084d4dec Cr-Commit-Position: refs/heads/master@{#292516}

Patch Set 1 #

Patch Set 2 : Fixing unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -7 lines) Patch
M components/url_fixer/url_fixer.cc View 1 2 chunks +16 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Mr4D (OOO till 08-26)
skuhne@chromium.org changed reviewers: + pkasting@chromium.org
6 years, 3 months ago (2014-08-28 20:07:39 UTC) #1
Mr4D (OOO till 08-26)
Please have a look. Note: $HOME should not be used for various reasons. To address ...
6 years, 3 months ago (2014-08-28 20:08:38 UTC) #2
Peter Kasting
LGTM
6 years, 3 months ago (2014-08-28 20:10:40 UTC) #3
Mr4D (OOO till 08-26)
The CQ bit was checked by skuhne@chromium.org
6 years, 3 months ago (2014-08-28 20:11:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/515973003/1
6 years, 3 months ago (2014-08-28 20:12:22 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-28 21:08:43 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-28 21:22:43 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/10169)
6 years, 3 months ago (2014-08-28 21:22:44 UTC) #8
Mr4D (OOO till 08-26)
The CQ bit was checked by skuhne@chromium.org
6 years, 3 months ago (2014-08-28 21:46:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/515973003/20001
6 years, 3 months ago (2014-08-28 21:47:41 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel_swarming on tryserver.chromium.mac ...
6 years, 3 months ago (2014-08-28 23:27:51 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001) as c7f70e2a76b4c4fa5ac00610d9d1e07977cf30c3
6 years, 3 months ago (2014-08-29 00:14:29 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:04:10 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/66e0255cea8ef64f16cc74b9579c1c37084d4dec
Cr-Commit-Position: refs/heads/master@{#292516}

Powered by Google App Engine
This is Rietveld 408576698