Mojo: Add a WebSocket/Client interface and hook it up to the HTML viewer.

Mojo: Add a WebSocket/Client interface and hook it up to the HTML viewer.

It's only half-implemented, but it's the half that lets you connect and
send/receive messages, so this seemed like a good stopping point.

BUG=403930
Committed: https://crrev.com/e7dfd32909a96c6496749a70cc8b8755a9069321
Cr-Commit-Position: refs/heads/master@{#293096}

[Matt Perry, 2014-08-28 22:09:18]

mpcomplete@chromium.org changed reviewers:
+ darin@chromium.org

[darin (slow to review), 2014-08-28 22:42:16]

LGTM

https://codereview.chromium.org/515923003/diff/1/mojo/services/html_viewer/bl...
File mojo/services/html_viewer/blink_platform_impl.cc (right):

https://codereview.chromium.org/515923003/diff/1/mojo/services/html_viewer/bl...
mojo/services/html_viewer/blink_platform_impl.cc:155: // TODO(mpcomplete):
what's this for?
This is the legacy way that Blink implemented websockets. If you can avoid
implementing this function you should. If it is needed, then perhaps all that is
needed is a NULL return value to signal that the new createWebSocketHandle()
method should be used.

[Matt Perry, 2014-08-28 23:24:21]

https://codereview.chromium.org/515923003/diff/1/mojo/services/html_viewer/bl...
File mojo/services/html_viewer/blink_platform_impl.cc (right):

https://codereview.chromium.org/515923003/diff/1/mojo/services/html_viewer/bl...
mojo/services/html_viewer/blink_platform_impl.cc:155: // TODO(mpcomplete):
what's this for?
On 2014/08/28 22:42:15, darin wrote:
> This is the legacy way that Blink implemented websockets. If you can avoid
> implementing this function you should. If it is needed, then perhaps all that
is
> needed is a NULL return value to signal that the new createWebSocketHandle()
> method should be used.

Cool, looks like it's not needed.

[Matt Perry, 2014-08-28 23:24:24]

The CQ bit was checked by mpcomplete@chromium.org

[commit-bot: I haz the power, 2014-08-28 23:26:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/515923003/20001

[commit-bot: I haz the power, 2014-08-29 00:22:49]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[commit-bot: I haz the power, 2014-08-29 00:29:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-29 00:29:33]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[Matt Perry, 2014-09-03 00:51:43]

The CQ bit was checked by mpcomplete@chromium.org

[commit-bot: I haz the power, 2014-09-03 00:53:33]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mpcomplete@chromium.org/515923003/60001

[commit-bot: I haz the power, 2014-09-03 07:52:23]

Committed patchset #4 (id:60001) as f37df0a98236ced12a513fad4c6cf3674312d022

[commit-bot: I haz the power, 2014-09-10 03:24:22]

Patchset 4 (id:??) landed as
https://crrev.com/e7dfd32909a96c6496749a70cc8b8755a9069321
Cr-Commit-Position: refs/heads/master@{#293096}