Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 515893002: Fix ARB regexp (Closed)

Created:
6 years, 3 months ago by borenet
Modified:
6 years, 3 months ago
Reviewers:
szager1, eseidel
CC:
chromium-reviews, pgervais+watch_chromium.org, kjellander-cc_chromium.org, cmp-cc_chromium.org, ilevy-cc_chromium.org, stip+watch_chromium.org
Project:
tools
Visibility:
Public.

Description

Fix ARB regexp This was causing a failure for DEPS which had comments at end of line. BUG=406867 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=291707

Patch Set 1 #

Patch Set 2 : Add a comment to DEPS_CONTENT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M scripts/tools/blink_roller/auto_roll.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/tools/blink_roller/auto_roll_test.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
borenet
borenet@google.com changed reviewers: + eseidel@chromium.org, szager@chromium.org
6 years, 3 months ago (2014-08-28 13:57:15 UTC) #1
borenet
6 years, 3 months ago (2014-08-28 13:57:15 UTC) #2
eseidel
Test please. Otherwise lgtm.
6 years, 3 months ago (2014-08-28 14:32:04 UTC) #3
eseidel
The CQ bit was checked by eseidel@chromium.org
6 years, 3 months ago (2014-08-28 14:37:58 UTC) #4
eseidel
lgtm
6 years, 3 months ago (2014-08-28 14:37:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/borenet@google.com/515893002/20001
6 years, 3 months ago (2014-08-28 14:38:27 UTC) #6
borenet
On 2014/08/28 14:32:04, eseidel wrote: > Test please. Otherwise lgtm. Added a comment to DEPS_CONTENT. ...
6 years, 3 months ago (2014-08-28 14:39:06 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-28 14:39:24 UTC) #8
commit-bot: I haz the power
Presubmit check for 515893002-20001 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 3 months ago (2014-08-28 14:39:25 UTC) #9
szager1
lgtm
6 years, 3 months ago (2014-08-28 15:41:12 UTC) #10
borenet
The CQ bit was checked by borenet@google.com
6 years, 3 months ago (2014-08-28 16:31:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/borenet@google.com/515893002/20001
6 years, 3 months ago (2014-08-28 16:31:57 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-08-28 16:33:01 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 291707

Powered by Google App Engine
This is Rietveld 408576698