"ctrl + double click" acts on the highlighted/selected bookmark list items irrespective of on which…

chrome/browser/resources/bookmark_manager/js/main.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 (function() {
 /** @const */ var BookmarkList = bmm.BookmarkList;
 /** @const */ var BookmarkTree = bmm.BookmarkTree;
 /** @const */ var Command = cr.ui.Command;
 /** @const */ var CommandBinding = cr.ui.CommandBinding;
 /** @const */ var LinkKind = cr.LinkKind;
@@ skipping 221 matching lines @@
     // We need to verify that this is a correct ID.
     chrome.bookmarks.get(id, function(items) {
       if (items && items.length == 1)
         updateParentId(id);
     });
   }
 }
 
 // Activate is handled by the open-in-same-window-command.
 function handleDoubleClickForList(e) {
+  var target = e.target;
+  target = list.getListItemAncestor(target);
+
+  var index = target ? list.getIndexOfListItem(target) : -1;
+  var sm = list.selectionModel;
+  var indexSelected = sm.getIndexSelected(index);
+  if (!indexSelected)

[arv (Not doing code reviews), 2014/09/02 17:17:32]

index 0 is also a valid index.

[b.rout, 2014/09/03 09:01:13]

right, index 0 is a valid index. But, getIndexSelected will tell if the index is
selected, which is captured in indexSelected variable. Sorry, I am just
wondering what is wrong here.

[arv (Not doing code reviews), 2014/09/04 15:19:20]

You are right. I was not reading this thoroughly.

+    list.handlePointerDownUp_(e);

[arv (Not doing code reviews), 2014/09/02 17:17:32]

This does not seem like the correct fix.

The list itself handles selection and we want the selection to be updated on
dblclick. My suggestion is to add a dblclick listener in cr/ui/list.js instead.

[b.rout, 2014/09/03 09:01:13]

There is already a dblclick listener in the cr/ui/list.js. But, I think list.js
covers common event handling functionalities. And the list in bookmark manager
is specific to bookmark. I think there might be other users of list. So, I am
doubtful if this change could be applied to common event handling fucntionality
of the list. Need a bit of insight and your advice.

[arv (Not doing code reviews), 2014/09/04 15:19:20]

I would prefer that this is handled in list. A Ctrl+dblclick should update the
selection in list, which happens before this dblclick handler is called.

[b.rout, 2014/09/05 09:16:53]

Done.

+
   if (e.button == 0)
     $('open-in-same-window-command').execute();
 }
 
 // The list dispatches an event when the user clicks on the URL or the Show in
 // folder part.
 function handleUrlClickedForList(e) {
   getLinkController().openUrlFromEvent(e.url, e.originalEvent);
   chrome.bookmarkManagerPrivate.recordLaunch();
 }
@@ skipping 1117 matching lines @@
 
   cr.ui.FocusOutlineManager.forDocument(document);
   initializeSplitter();
   bmm.addBookmarkModelListeners();
   dnd.init(selectItemsAfterUserAction);
   tree.reload();
 }
 
 initializeBookmarkManager();
 })();