Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 515843002: Adds accessibility role for figure tag and handles its children as a group. (Closed)

Created:
6 years, 3 months ago by je_julie(Not used)
Modified:
6 years, 3 months ago
Reviewers:
dmazzoni
CC:
blink-reviews, jamesr, dglazkov+blink, dmazzoni, aboxhall, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Adds accessibility role for figure tag and handles its children as a group. figure tag can have several children. This patch makes its children a group for accessibility role. BUG=282040 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181203

Patch Set 1 #

Patch Set 2 : added role for some case without renderer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M Source/core/accessibility/AXNodeObject.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/accessibility/AXObject.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/accessibility/AXRenderObject.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
M Source/web/AssertMatchingEnums.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M public/web/WebAXEnums.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
je_julie(Not used)
je_julie.kim@samsung.com changed reviewers: + dmazzoni@chromium.org
6 years, 3 months ago (2014-08-28 08:25:41 UTC) #1
je_julie(Not used)
dmazzoni, PTAL.
6 years, 3 months ago (2014-08-29 10:32:43 UTC) #2
dmazzoni
Please add this to AXNodeObject::determineAccessibilityRole too - though unfinished, that variant is used in a ...
6 years, 3 months ago (2014-08-29 11:06:54 UTC) #3
je_julie(Not used)
On 2014/08/29 11:06:54, dmazzoni wrote: > Please add this to AXNodeObject::determineAccessibilityRole too - though > ...
6 years, 3 months ago (2014-08-29 13:31:21 UTC) #4
dmazzoni
lgtm +dglazkov for public/web
6 years, 3 months ago (2014-09-01 06:49:24 UTC) #6
dmazzoni
Oops, just realized no extra lgtm needed for this change. I'll press the commit queue ...
6 years, 3 months ago (2014-09-01 21:08:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/je_julie.kim@samsung.com/515843002/20001
6 years, 3 months ago (2014-09-01 21:09:23 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_rel on tryserver.blink ...
6 years, 3 months ago (2014-09-01 22:16:30 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-01 22:42:44 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 181203

Powered by Google App Engine
This is Rietveld 408576698