Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3063)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

Issue 515803002: Change security warning links to point to localized help center article (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc b/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
index 31e195d5c62b00778515c53bb58e256d9b3332bb..20c2c354dfdb4b6694e4aaa08034c0fde2993c90 100644
--- a/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
@@ -302,23 +302,34 @@ void SafeBrowsingBlockingPage::CommandReceived(const std::string& cmd) {
if (command == kLearnMoreCommand) {
// User pressed "Learn more".
- GURL url(interstitial_type_ == TYPE_PHISHING ?
- kLearnMorePhishingUrlV2 : kLearnMoreMalwareUrlV2);
#if defined(ENABLE_EXTENSIONS)
if (sampling_event_.get())
sampling_event_->set_has_viewed_learn_more(true);
#endif
- OpenURLParams params(
- url, Referrer(), CURRENT_TAB, content::PAGE_TRANSITION_LINK, false);
+ GURL learn_more_url(interstitial_type_ == TYPE_PHISHING ?
+ kLearnMorePhishingUrlV2 : kLearnMoreMalwareUrlV2);
+ learn_more_url = google_util::AppendGoogleLocaleParam(
+ learn_more_url, g_browser_process->GetApplicationLocale());
+ OpenURLParams params(learn_more_url,
+ Referrer(),
+ CURRENT_TAB,
+ content::PAGE_TRANSITION_LINK,
+ false);
web_contents_->OpenURL(params);
return;
}
if (command == kShowPrivacyCommand) {
// User pressed "Safe Browsing privacy policy".
- GURL url(l10n_util::GetStringUTF8(IDS_SAFE_BROWSING_PRIVACY_POLICY_URL));
- OpenURLParams params(
- url, Referrer(), CURRENT_TAB, content::PAGE_TRANSITION_LINK, false);
+ GURL privacy_url(
+ l10n_util::GetStringUTF8(IDS_SAFE_BROWSING_PRIVACY_POLICY_URL));
+ privacy_url = google_util::AppendGoogleLocaleParam(
+ privacy_url, g_browser_process->GetApplicationLocale());
+ OpenURLParams params(privacy_url,
+ Referrer(),
+ CURRENT_TAB,
+ content::PAGE_TRANSITION_LINK,
+ false);
web_contents_->OpenURL(params);
return;
}

Powered by Google App Engine
This is Rietveld 408576698