Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 515803002: Change security warning links to point to localized help center article (Closed)

Created:
6 years, 3 months ago by felt
Modified:
6 years, 3 months ago
Reviewers:
palmer, mattm
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Change security warning links to point to localized help center article BUG=402934 Committed: https://crrev.com/e5d8ace7ccebe3c2e4c93f9151f9f482c982dc69 Cr-Commit-Position: refs/heads/master@{#292508}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -9 lines) Patch
M chrome/browser/safe_browsing/download_protection_service.cc View 3 chunks +4 lines, -0 lines 2 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page.cc View 1 chunk +18 lines, -7 lines 0 comments Download
M chrome/browser/ssl/ssl_blocking_page.cc View 4 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
felt
felt@chromium.org changed reviewers: + mattm@chromium.org, palmer@chromium.org
6 years, 3 months ago (2014-08-28 03:21:22 UTC) #1
felt
palmer: pls review c/b/ssl/ssl_blocking_page.cc mattm: pls review c/b/safe_browsing/*
6 years, 3 months ago (2014-08-28 03:21:58 UTC) #2
palmer
lgtm
6 years, 3 months ago (2014-08-28 18:46:20 UTC) #3
mattm
https://codereview.chromium.org/515803002/diff/1/chrome/browser/safe_browsing/download_protection_service.cc File chrome/browser/safe_browsing/download_protection_service.cc (right): https://codereview.chromium.org/515803002/diff/1/chrome/browser/safe_browsing/download_protection_service.cc#newcode963 chrome/browser/safe_browsing/download_protection_service.cc:963: GURL learn_more_url(chrome::kDownloadScanningLearnMoreURL); This one doesn't seem to work, I ...
6 years, 3 months ago (2014-08-28 21:07:59 UTC) #4
felt
https://codereview.chromium.org/515803002/diff/1/chrome/browser/safe_browsing/download_protection_service.cc File chrome/browser/safe_browsing/download_protection_service.cc (right): https://codereview.chromium.org/515803002/diff/1/chrome/browser/safe_browsing/download_protection_service.cc#newcode963 chrome/browser/safe_browsing/download_protection_service.cc:963: GURL learn_more_url(chrome::kDownloadScanningLearnMoreURL); On 2014/08/28 21:07:58, mattm wrote: > This ...
6 years, 3 months ago (2014-08-28 21:54:23 UTC) #5
mattm
On 2014/08/28 21:54:23, felt wrote: > https://codereview.chromium.org/515803002/diff/1/chrome/browser/safe_browsing/download_protection_service.cc > File chrome/browser/safe_browsing/download_protection_service.cc (right): > > https://codereview.chromium.org/515803002/diff/1/chrome/browser/safe_browsing/download_protection_service.cc#newcode963 > ...
6 years, 3 months ago (2014-08-28 22:05:22 UTC) #6
felt
The CQ bit was checked by felt@chromium.org
6 years, 3 months ago (2014-08-28 22:09:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/felt@chromium.org/515803002/1
6 years, 3 months ago (2014-08-28 22:11:11 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as 97f4265a3900cfc61fba8012e29de0430e5a67f7
6 years, 3 months ago (2014-08-28 23:51:41 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:03:54 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e5d8ace7ccebe3c2e4c93f9151f9f482c982dc69
Cr-Commit-Position: refs/heads/master@{#292508}

Powered by Google App Engine
This is Rietveld 408576698