Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 515793002: Disable running some instruction selector test on unsupported backends. (Closed)

Created:
6 years, 3 months ago by chunyang.dai
Modified:
6 years, 3 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/external/v8.git@bleeding_edge
Project:
v8
Visibility:
Public.

Description

Disable running some instruction selector test on unsupported backends. BUG= R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23485

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M test/compiler-unittests/instruction-selector-unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
chunyang.dai
chunyang.dai@intel.com changed reviewers: + jarin@chromium.org
6 years, 3 months ago (2014-08-28 02:55:50 UTC) #1
chunyang.dai
hello. Jarin. this test case calls v8::internal::compiler::Linkage::GetStubCallDescriptor but this function is only implemented for turbofan ...
6 years, 3 months ago (2014-08-28 03:01:08 UTC) #2
Weiliang
On 2014/08/28 03:01:08, chunyang.dai wrote: > hello. Jarin. > this test case calls v8::internal::compiler::Linkage::GetStubCallDescriptor but ...
6 years, 3 months ago (2014-08-28 03:16:19 UTC) #3
chunyang.dai
updated it. thanks.
6 years, 3 months ago (2014-08-28 03:26:14 UTC) #4
chunyang.dai
Patchset #2 (id:20001) has been deleted
6 years, 3 months ago (2014-08-28 03:34:22 UTC) #5
Jarin
lgtm
6 years, 3 months ago (2014-08-28 06:50:13 UTC) #6
chunyang.dai
hello. Jarin. Please help to commit it. thanks
6 years, 3 months ago (2014-08-28 09:27:34 UTC) #7
Jarin
6 years, 3 months ago (2014-08-28 11:06:37 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 manually as 23485 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698