Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Unified Diff: components/gcm_driver/default_gcm_app_handler.cc

Issue 515763002: [GCM] Extracting GCMConnectionObserver from GCMAppHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing CR feedback Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/gcm_driver/default_gcm_app_handler.h ('k') | components/gcm_driver/fake_gcm_app_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/gcm_driver/default_gcm_app_handler.cc
diff --git a/components/gcm_driver/default_gcm_app_handler.cc b/components/gcm_driver/default_gcm_app_handler.cc
index 25836731f176941b460a44bfefd964c49db52b77..07fc6e6a30e02d26712c96ac92741e41c5361a9a 100644
--- a/components/gcm_driver/default_gcm_app_handler.cc
+++ b/components/gcm_driver/default_gcm_app_handler.cc
@@ -5,7 +5,6 @@
#include "components/gcm_driver/default_gcm_app_handler.h"
#include "base/logging.h"
-#include "net/base/ip_endpoint.h"
namespace gcm {
@@ -42,14 +41,4 @@ void DefaultGCMAppHandler::OnSendAcknowledged(const std::string& app_id,
<< app_id;
}
-void DefaultGCMAppHandler::OnConnected(const net::IPEndPoint& ip_endpoint) {
- // TODO(semenzato): update CrOS NIC state.
- DVLOG(1) << "GCM connected to " << ip_endpoint.ToString();
-}
-
-void DefaultGCMAppHandler::OnDisconnected() {
- // TODO(semenzato): update CrOS NIC state.
- DVLOG(1) << "GCM disconnected";
-}
-
} // namespace gcm
« no previous file with comments | « components/gcm_driver/default_gcm_app_handler.h ('k') | components/gcm_driver/fake_gcm_app_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698