Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: components/gcm_driver/gcm_driver.cc

Issue 515763002: [GCM] Extracting GCMConnectionObserver from GCMAppHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Finishing the CL on a box that compiles much faster... Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/gcm_driver/gcm_driver.cc
diff --git a/components/gcm_driver/gcm_driver.cc b/components/gcm_driver/gcm_driver.cc
index e9ff81975aac5f9d4b4bd064bcf67c4216761314..4d3e601cfa8556db097bf60ffc23c45d104b9f7c 100644
--- a/components/gcm_driver/gcm_driver.cc
+++ b/components/gcm_driver/gcm_driver.cc
@@ -185,6 +185,12 @@ GCMAppHandler* GCMDriver::GetAppHandler(const std::string& app_id) {
return &default_app_handler_;
}
+void GCMDriver::AddConnectionObserver(GCMConnectionObserver* observer) {
+}
jianli 2014/08/27 23:34:17 Please comment that connection observing is only s
fgorski 2014/08/27 23:51:45 Done. Made abstract in GCMDriver and moved empty m
+
+void GCMDriver::RemoveConnectionObserver(GCMConnectionObserver* observer) {
+}
+
bool GCMDriver::HasRegisterCallback(const std::string& app_id) {
return register_callbacks_.find(app_id) != register_callbacks_.end();
}

Powered by Google App Engine
This is Rietveld 408576698