components/gcm_driver/gcm_app_handler.cc - Issue 515763002: [GCM] Extracting GCMConnectionObserver from GCMAppHandler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/gcm_driver/gcm_app_handler.cc

Issue 515763002: [GCM] Extracting GCMConnectionObserver from GCMAppHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Finishing the CL on a box that compiles much faster... Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/gcm_driver/gcm_app_handler.h ('k') | components/gcm_driver/gcm_connection_observer.h » ('j') | components/gcm_driver/gcm_connection_observer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/gcm_driver/gcm_app_handler.cc

diff --git a/components/gcm_driver/gcm_app_handler.cc b/components/gcm_driver/gcm_app_handler.cc

index ed00cbe1e3ffebf9ccb03f67cb34a313cd853d57..d7c66f3b0549707d5fb2554df1c87bcf1fc3bf4d 100644

--- a/components/gcm_driver/gcm_app_handler.cc

+++ b/components/gcm_driver/gcm_app_handler.cc

@@ -9,12 +9,6 @@ namespace gcm {

GCMAppHandler::GCMAppHandler() {}

GCMAppHandler::~GCMAppHandler() {}

-void GCMAppHandler::OnConnected(const net::IPEndPoint& ip_endpoint) {

-void GCMAppHandler::OnDisconnected() {

bool GCMAppHandler::CanHandle(const std::string& app_id) const {

return false;

}