components/gcm_driver/fake_gcm_app_handler.h - Issue 515763002: [GCM] Extracting GCMConnectionObserver from GCMAppHandler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/gcm_driver/fake_gcm_app_handler.h

Issue 515763002: [GCM] Extracting GCMConnectionObserver from GCMAppHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Finishing the CL on a box that compiles much faster... Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/gcm_driver/default_gcm_app_handler.cc ('k') | components/gcm_driver/fake_gcm_app_handler.cc » ('j') | components/gcm_driver/gcm_connection_observer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/gcm_driver/fake_gcm_app_handler.h

diff --git a/components/gcm_driver/fake_gcm_app_handler.h b/components/gcm_driver/fake_gcm_app_handler.h

index a59a1c24746da7be8eb7928596c7a56b5e4086b9..eb09422f00f17be94ca6a30700c56a740a86f800 100644

--- a/components/gcm_driver/fake_gcm_app_handler.h

+++ b/components/gcm_driver/fake_gcm_app_handler.h

@@ -34,7 +34,6 @@ class FakeGCMAppHandler : public GCMAppHandler {

const GCMClient::SendErrorDetails& send_error_details() const {

return send_error_details_;

}

- bool connected() const { return connected_; }

void WaitForNotification();

@@ -48,8 +47,6 @@ class FakeGCMAppHandler : public GCMAppHandler {

const GCMClient::SendErrorDetails& send_error_details) OVERRIDE;

virtual void OnSendAcknowledged(const std::string& app_id,

const std::string& message_id) OVERRIDE;

- virtual void OnConnected(const net::IPEndPoint& ip_endpoint) OVERRIDE;

- virtual void OnDisconnected() OVERRIDE;

private:

void ClearResults();

@@ -61,7 +58,6 @@ class FakeGCMAppHandler : public GCMAppHandler {

std::string acked_message_id_;

GCMClient::IncomingMessage message_;

GCMClient::SendErrorDetails send_error_details_;

- bool connected_;

DISALLOW_COPY_AND_ASSIGN(FakeGCMAppHandler);

};