content/browser/service_worker/service_worker_request_handler.h - Issue 515753003: Add ServiceWorker timing information on the popup panel in DevTools's Network tab (2/2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_request_handler.h

Issue 515753003: Add ServiceWorker timing information on the popup panel in DevTools's Network tab (2/2) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporate the reviews Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_controllee_request_handler.cc ('k') | content/browser/service_worker/service_worker_url_request_job.h » ('j') | content/browser/service_worker/service_worker_url_request_job.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_request_handler.h

diff --git a/content/browser/service_worker/service_worker_request_handler.h b/content/browser/service_worker/service_worker_request_handler.h

index c8cebafedcf59854005f22f3228e714f0dd9ea0f..910d5bb6e89f8f5f17c5ac45f35c7f4761581490 100644

--- a/content/browser/service_worker/service_worker_request_handler.h

+++ b/content/browser/service_worker/service_worker_request_handler.h

@@ -8,6 +8,7 @@

#include "base/basictypes.h"

#include "base/memory/weak_ptr.h"

#include "base/supports_user_data.h"

+#include "base/time/time.h"

#include "content/common/content_export.h"

#include "content/common/service_worker/service_worker_status_code.h"

#include "content/public/common/resource_type.h"

@@ -67,7 +68,10 @@ class CONTENT_EXPORT ServiceWorkerRequestHandler

virtual void GetExtraResponseInfo(

bool* was_fetched_via_service_worker,

- GURL* original_url_via_service_worker) const = 0;

+ GURL* original_url_via_service_worker,

+ base::TimeTicks* fetch_start_time,

+ base::TimeTicks* fetch_ready_time,

+ base::TimeTicks* fetch_end_time) const = 0;

protected:

ServiceWorkerRequestHandler(