content/browser/service_worker/service_worker_context_request_handler.cc - Issue 515753003: Add ServiceWorker timing information on the popup panel in DevTools's Network tab (2/2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_context_request_handler.cc

Issue 515753003: Add ServiceWorker timing information on the popup panel in DevTools's Network tab (2/2) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporate the reviews Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_context_request_handler.h ('k') | content/browser/service_worker/service_worker_controllee_request_handler.h » ('j') | content/browser/service_worker/service_worker_url_request_job.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_context_request_handler.cc

diff --git a/content/browser/service_worker/service_worker_context_request_handler.cc b/content/browser/service_worker/service_worker_context_request_handler.cc

index c30598539d4ddeba4a460e11b92a3c7d62cf15e4..81e84ebcd83069c417d99e22223e1672627931d2 100644

--- a/content/browser/service_worker/service_worker_context_request_handler.cc

+++ b/content/browser/service_worker/service_worker_context_request_handler.cc

@@ -4,6 +4,7 @@

#include "content/browser/service_worker/service_worker_context_request_handler.h"

+#include "base/time/time.h"

#include "content/browser/service_worker/service_worker_context_core.h"

#include "content/browser/service_worker/service_worker_provider_host.h"

#include "content/browser/service_worker/service_worker_read_from_cache_job.h"

@@ -89,7 +90,10 @@ net::URLRequestJob* ServiceWorkerContextRequestHandler::MaybeCreateJob(

void ServiceWorkerContextRequestHandler::GetExtraResponseInfo(

bool* was_fetched_via_service_worker,

- GURL* original_url_via_service_worker) const {

+ GURL* original_url_via_service_worker,

+ base::TimeTicks* fetch_start_time,

+ base::TimeTicks* fetch_ready_time,

+ base::TimeTicks* fetch_end_time) const {

*was_fetched_via_service_worker = false;

*original_url_via_service_worker = GURL();

}