Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1165)

Unified Diff: content/browser/service_worker/service_worker_url_request_job.h

Issue 515753003: Add ServiceWorker timing information on the popup panel in DevTools's Network tab (2/2) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Incorporate the review Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_url_request_job.h
diff --git a/content/browser/service_worker/service_worker_url_request_job.h b/content/browser/service_worker/service_worker_url_request_job.h
index 644ffad6874b4bb118ca39a469612d915cc5cd8d..8b8fff3d5c5be1b2cbaa024e7ba66634f80c27ae 100644
--- a/content/browser/service_worker/service_worker_url_request_job.h
+++ b/content/browser/service_worker/service_worker_url_request_job.h
@@ -57,6 +57,8 @@ class CONTENT_EXPORT ServiceWorkerURLRequestJob
virtual bool GetCharset(std::string* charset) OVERRIDE;
virtual bool GetMimeType(std::string* mime_type) const OVERRIDE;
virtual void GetResponseInfo(net::HttpResponseInfo* info) OVERRIDE;
+ virtual void GetLoadTimingInfo(net::LoadTimingInfo* load_timing_info)
+ const OVERRIDE;
mmenke 2014/09/02 19:10:43 nit: 4 space indent.
mmenke 2014/09/02 19:10:43 nit: Close parentheses and const/OVERRIDE should
shimazu 2014/09/04 03:32:41 Done.
virtual int GetResponseCode() const OVERRIDE;
virtual void SetExtraRequestHeaders(
const net::HttpRequestHeaders& headers) OVERRIDE;
@@ -131,6 +133,8 @@ class CONTENT_EXPORT ServiceWorkerURLRequestJob
base::WeakPtr<ServiceWorkerProviderHost> provider_host_;
+ net::LoadTimingInfo load_timing_info_;
+ base::Time response_time_;
ResponseType response_type_;
bool is_started_;

Powered by Google App Engine
This is Rietveld 408576698