Add ServiceWorker timing information on the popup panel in DevTools's Network tab (2/2)

net/base/load_timing_info.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_BASE_LOAD_TIMING_INFO_H_
 #define NET_BASE_LOAD_TIMING_INFO_H_
 
 #include "base/basictypes.h"
 #include "base/time/time.h"
 #include "net/base/net_export.h"
@@ skipping 73 matching lines @@
     base::TimeTicks connect_start;
     base::TimeTicks connect_end;
 
     // The time when the SSL handshake started / completed. For non-HTTPS
     // requests these are null.  These times are only for the SSL connection to
     // the final destination server, not an SSL/SPDY proxy.
     base::TimeTicks ssl_start;
     base::TimeTicks ssl_end;
   };
 
+  // Contains the timing of ServiceWorker.
+  // These are all set by ServiceWrokerURLRequestJob.
+  struct NET_EXPORT_PRIVATE ServiceWorkerTiming {

[mmenke, 2014/09/02 19:10:43]

It's a layering violation for net/ to know about ServiceWorkerURLRequestJobs, or
service workers in general.  Suggest adding the new times directly to
ResourceResponseInfo, and setting them in PopulateResourceResponse.

There are a couple ways to attach them to the request - if you keep track of
ServiceWorkerURLRequestJobs somewhere, could find the right one for a request
and grab them directly.  If not, could attach them to the URLRequest via the
SupportsUserData API.  Open to other ideas.

[shimazu, 2014/09/04 03:32:41]

Thanks for your comment, and I tried the implementation as you said.
ServiceWorker's timing info is contained by ServiceWorkerURLRequestJob directly
and passed to ResourceResponseInfo via GetExtraResponseInfo().
On 2014/09/02 19:10:43, mmenke wrote:

+    ServiceWorkerTiming();
+    ~ServiceWorkerTiming();
+
+    base::TimeTicks fetch_start;
+    base::TimeTicks fetch_ready;
+    base::TimeTicks fetch_end;
+  };
+
   LoadTimingInfo();
   ~LoadTimingInfo();
 
   // True if the socket was reused.  When true, DNS, connect, and SSL times
   // will all be null.  When false, those times may be null, too, for non-HTTP
   // requests, or when they don't apply to a request.
   //
   // For requests that are sent again after an AUTH challenge, this will be true
   // if the original socket is reused, and false if a new socket is used.
   // Responding to a proxy AUTH challenge is never considered to be reusing a
@@ skipping 16 matching lines @@
   // changes.
   base::Time request_start_time;
 
   base::TimeTicks request_start;
 
   // The time spent determing which proxy to use.  Null when there is no PAC.
   base::TimeTicks proxy_resolve_start;
   base::TimeTicks proxy_resolve_end;
 
   ConnectTiming connect_timing;
+  ServiceWorkerTiming serviceworker_timing;
 
   // The time that sending HTTP request started / ended.
   base::TimeTicks send_start;
   base::TimeTicks send_end;
 
   // The time at which the end of the HTTP headers were received.
   base::TimeTicks receive_headers_end;
 };
 
 }  // namespace net
 
 #endif  // NET_BASE_LOAD_TIMING_INFO_H_